Re: [PATCH linux-next] drm/amd/display: give the dprx CRC test its connector state back
From: Mark Brown
Date: Wed Nov 11 2026 - 11:52:30 EST
On Wed, Nov 11, 2026 at 11:14:27AM -0500, Sasha Levin wrote:
> The merge fixup in commit c62c2736d82f ("amdgpu: Merge merge merge
> cherry-pick cherry-pick cherry-pick") dropped the call to
> drm_atomic_helper_connector_reset(), which drm-misc removed. But that
> call is what gave the test's connector a state, so the assert right
> after it always fails now.
> Create the state with drm_atomic_helper_connector_create_state()
> instead, and check it before storing it: cleanup would choke on an
> error pointer in connector->state.
Yeah, that fixup was obviously just a build fixup rather than an attempt
to actually get things working.
Attachment:
signature.asc
Description: PGP signature