Re: [PATCH v3 1/4] drm/msm: Resume devfreq from each GPU's resume callback

From: Dmitry Baryshkov

Date: Wed Nov 11 2026 - 11:55:39 EST


On Sat, Nov 07, 2026 at 05:26:07PM -0300, Fabricio Akio wrote:
> msm_gpu_pm_resume() resumes devfreq, which samples the GPU's busy
> counter as the baseline of its next poll. A resume callback that resets
> the GPU after msm_gpu_pm_resume() clears that counter, and the next
> poll then subtracts the old count from the new one and wraps.
>
> Move the call out of msm_gpu_pm_resume() into the resume callbacks that
> use it, as A6xx already does, so that each GPU can resume devfreq once
> its hardware is ready. The A3xx, A4xx and A5xx callbacks call it right
> after msm_gpu_pm_resume(), where it ran before, so nothing changes yet.
> A2xx has no gpu_busy callback, so it has no devfreq.
>
> Suggested-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Fabricio Akio <fabricioakio@xxxxxxxxx>
> ---
> New in v3.
>
> Tested on A508 only; the A3xx and A4xx callbacks call it where
> msm_gpu_pm_resume() did.
> ---
> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 15 ++++++++++++++-
> drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 2 ++
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++
> drivers/gpu/drm/msm/msm_gpu.c | 2 --
> 4 files changed, 18 insertions(+), 3 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


--
With best wishes
Dmitry