Re: [PATCH 1/4] virtio_console: copy pipe buffers in splice_write()
From: Linus Torvalds
Date: Wed Nov 11 2026 - 12:01:42 EST
On Wed, 11 Nov 2026 at 05:42, Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> So the fix below is what we've done before for pipes and I think it's
> the right thing to do here too. I put the following on vfs.fixes:
Please no.
> - src = kmap_local_page(buf->page);
> - memcpy(page_address(page) + offset, src + buf->offset, len);
> - kunmap_local(src);
This boils down to one memcpy.
HIGHMEM is dead. Nobody sane uses it. It *will* go away. It's already
effectively never ever used.
There are some broken 32-bit arm setups that use it, and legacy museum
32-bit x86.
Don't make one memcpy() that can be inlined become this garbage:
> + /* The buffer can span several pages of a compound page. */
> + kv.iov_base = page_address(page) + offset;
> + kv.iov_len = len;
> + iov_iter_kvec(&to, ITER_DEST, &kv, 1, len);
> + if (copy_page_to_iter(buf->page, buf->offset, len, &to) != len) {
> + __free_page(page);
> + return -EFAULT;
> + }
just because of broken shit that nobody has ever complained about or ever hit.
Linus