Re: [PATCH][next] drm/amdgpu: make the read-only const array fw_err_code_msg static
From: Alex Deucher
Date: Wed Nov 11 2026 - 12:20:48 EST
Reviewed and applied. Thanks!
On Tue, Nov 10, 2026 at 11:31 AM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> Don't populate the read-only const array fw_err_code_msg on the stack
> at run time, instead make it static
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
> index d025b4183b29..91c863649972 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
> @@ -5427,7 +5427,7 @@ static int amdgpu_ualink_metadata_init(struct amdgpu_device *adev)
> */
> static void amdgpu_ualink_remote_error(struct amdgpu_device *adev, u32 status)
> {
> - const char *fw_err_code_msg[] = {
> + static const char * const fw_err_code_msg[] = {
> "Unknown FW error status",
> "FIFO overflow", /* error code 1 */
> "Invalid RB command",
> --
> 2.55.0
>