Re: [PATCH v3 04/10] mm/vmalloc: propagate errors in vmap_pages_p*d_range()

From: Uladzislau Rezki

Date: Wed Nov 11 2026 - 12:31:18 EST


On Sun, Nov 1, 2026 at 5:00 PM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> On Fri, Oct 30, 2026 at 2:16 AM Hao Ge <hao.ge@xxxxxxxxx> wrote:
> >
> > Hi Dev
> >
> > Thanks for your review.
> >
> > On 2026/10/30 15:29, Dev Jain wrote:
> > >
> > >
> > > On 26/10/26 1:33 pm, Hao Ge wrote:
> > >> vmap_pages_pmd_range(), vmap_pages_pud_range() and
> > >> vmap_pages_p4d_range() return -ENOMEM whenever the level below them
> > >> fails. But vmap_pages_pte_range() can also return -EINVAL for a
> > >> page without a valid pfn and -EBUSY for a pte that is already
> > >> mapped. Pass the error up as-is instead, like the vmap_p*d_range()
> > >> helpers for vmap_page_range() do.
> > >>
> > >> Signed-off-by: Hao Ge <hao.ge@xxxxxxxxx>
> > >> ---
> > >
> > > Fixes?
> > >
> >
> > Sorry, I missed that.
> >
> > > Reviewed-by: Dev Jain <dev.jain@xxxxxxx>
> >
> > Thanks! If you have some time, I'd also appreciate a review of the
> > remaining patches in the series -- or Suren and Uladzislau, if they
> > get a chance. No rush, I know everyone is busy.
>
> Yep, it's in my review queue.
>
I see v4, so i will have a look!

--
Uladzislau Rezki