Re: [PATCH v5 6/7] arm64: dts: qcom: sdm845-google: Add basic audio support
From: David Heidelberg
Date: Wed Nov 11 2026 - 13:16:54 EST
On 15/10/2026 13:12, Konrad Dybcio wrote:
On 9/25/26 5:28 PM, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <david@xxxxxxx>
Introduce support for sound card and wire two CS35L36 audio codecs for
top and bottom speakers.
Inspired by commit from Joel Selvaraj.
Signed-off-by: David Heidelberg <david@xxxxxxx>
---
[...]
+&sound {
+ compatible = "qcom,sdm845-sndcard";
+ model = "Pixel 3";
+ pinctrl-0 = <&quat_mi2s_active>, <&quat_mi2s_sd0_active>,
+ <&quat_mi2s_sd1_active>;
+ pinctrl-names = "default";
+
+ /* mm[0-9]-dai-link nodes must be positioned first regardless of sorting */
This patch generally looks good minus this part. Will you be trying out
one of the suggestions that GPT gave you?
https://lore.kernel.org/linux-arm-msm/e4b32a40-4432-40c0-8e57-f5602c98f096@xxxxxxx/
When there will be consensus that all DT has to be sorted by linter or something, I assume it'll be part of the series changing it.
My capacity is not big enough to solve everything I see needs improvements in the kernel.
I can start fixing nice-to-have things when my tree (currently ~240 patches) will be empty and we could grab a phone with clean mainline and make a phone call from it. Not there yet, must focus on the ground work for now.
David
e.g.
"""
In the ASoC core: defer component routes until after
soc_probe_link_components() finishes, next to where the card routes are added.
That removes the dependency
for every driver with cross-component routes. It is a small change, but it
touches every card, so it needs a wide audience on alsa-devel.
"""
We've recently got some fresh wind on the DT linter, so house of cards
this may not live for long..
Konrad