Re: [PATCH 3/3] dt-bindings: display/msm: Require DSI graph endpoint
From: Dmitry Baryshkov
Date: Wed Nov 11 2026 - 13:23:32 EST
On Tue, Nov 10, 2026 at 01:57:44PM +0100, Krzysztof Kozlowski wrote:
> Technically, DSI controllers do not need OF graphs with endpoint to the
> panel and could rely directly on their child node (when panel is the
> child of DSI).
>
> However Linux Qualcomm MSM DRM DSI driver never implemented such
> approach and it requires a valid graph endpoint pointing to the panel.
> If it is missing, the drivers will silently accept such DTS in
> dsi_host_parse_dt(), but later fail on dsi_host_attach() because number
> of lanes is not initialized. The number of lanes is initialized to safe
> default only when there is a valid endpoint which is missing data-lanes.
>
> Extend the bindings to validate existing DTS to match expected ABI.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 6 ++++++
> .../devicetree/bindings/display/msm/qcom,milos-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml | 4 +++-
> .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 8 ++++++--
> .../devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sc8180x-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sdm670-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 1 +
> .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 2 ++
> .../devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml | 1 +
> 25 files changed, 48 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
Note to myself: per Rob's request this should be applied only after the
DTS changes.
--
With best wishes
Dmitry