Re: [PATCH] ASoC: qcom: audioreach: apply volume changes to a running graph
From: Mark Brown
Date: Wed Nov 11 2026 - 13:31:01 EST
> audioreach_put_vol_ctrl_audio_mixer() only stores the new gain in the
> module. The gain reaches the DSP from audioreach_pga_event() on
> SND_SOC_DAPM_POST_PMU, that is when a stream starts, so changing the
> "<stream> Playback Volume" control while playing has no effect until the
> next stream.
> +++ b/sound/soc/qcom/qdsp6/topology.c
> @@ -1323,8 +1323,19 @@ static int audioreach_put_vol_ctrl_audio_mixer(struct snd_kcontrol *kcontrol,
> {
> + /* The PGA event only applies the gain when the widget powers up */
> + if (dw->power) {
We don't have the DAPM lock here so this could change while the function
runs.
--
Mark Brown <broonie@xxxxxxxxxx>