Re: [PATCH v3] iio: gyro: bmg160: Discard pm_runtime_put_autosuspend() return values
From: Brian Norris
Date: Wed Nov 11 2026 - 13:37:31 EST
Hi Jonathan,
On Mon, Nov 02, 2026 at 01:16:02PM -0800, Brian Norris wrote:
> On Mon, Nov 02, 2026 at 01:48:30AM +0000, Jonathan Cameron wrote:
> > --- a/drivers/iio/gyro/bmg160_core.c
> > +++ b/drivers/iio/gyro/bmg160_core.c
> > - data->ev_enable_state = state;
>
> This is an unexpected (to me) delta vs v2: you've stopped setting
> data->ev_enable_state here. I think that's a regression.
>
> This is also one reason I think it's unwise to make so many changes
> together here. One person's "churn" (to apply several patches to similar
> code) is another person's "hard to review / easy to make mistakes".
Gentle ping on this one. I'd like to advance my
pm_runtime_put_autosuspend() series one way or another. I'm willing to
respin this one for you if you'd like, even if I'm still personally
hesitant to make so many of these changes together.
I'm also open to going back to a minimal series -- that only drops the
return codes, and inlines functions that are trivial candidates.
Your call.
Brian
>
> > - mutex_unlock(&data->mutex);
> > + pm_runtime_put_autosuspend(dev);
> > + }
> >
> > return 0;
> > }