Re: [PATCH 1/4] scripts/Kconfig.toolchain: Remove CONFIG_CC_HAS_NO_PROFILE_FN_ATTR

From: Nick Desaulniers

Date: Wed Nov 11 2026 - 14:30:26 EST


On Wed, Nov 11, 2026 at 11:10 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> On Wed, Nov 11, 2026 at 11:06:06AM -0800, Nick Desaulniers wrote:
> > On Tue, Nov 10, 2026 at 9:42 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > > index 04f4ebdc3cf5..f62de2dea8a3 100644
> > > --- a/kernel/gcov/Kconfig
> > > +++ b/kernel/gcov/Kconfig
> > > @@ -4,7 +4,6 @@ menu "GCOV-based kernel profiling"
> > > config GCOV_KERNEL
> > > bool "Enable gcov-based kernel profiling"
> > > depends on DEBUG_FS
> > > - depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR
> >
> > did you want to retain `depends on !ARCH_WANTS_NO_INSTR` (deleting the
> > ` || CC_HAS_NO_PROFILE_FN_ATTR`)?
>
> No. If CONFIG_CC_HAS_NO_PROFILE_FN_ATTR is always 'y', this whole
> 'depends on' line is 'y', so it can be removed entirely. The noinstr
> part of that dependency was only added because the "no profile"
> attribute is only relevant for noinstr.

SGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

--
Thanks,
~Nick Desaulniers