Re: [PATCH] MIPS: ingenic: Let Config.VI tell whether the icache is virtual
From: Hunter Laux
Date: Wed Nov 11 2026 - 15:05:54 EST
Hi Paul,
On Wed, 11 Nov 2026 17:23:31 +0100, Paul Cercueil wrote:
> The docs I have do say that both caches are "virtually indexed, physically
> tagged". So the patch looks good.
Thanks for checking.
> If anything it's missing a Fixes: tag (with stable@xxxxxxxxxxxxxxx in Cc).
I don't think it needs to go to stable. The vtag setting doesn't cause
wrong behaviour, only extra icache flushes. I can add a Fixes: tag
without Cc: stable if you'd like the origin recorded.
>> -#define cpu_has_vtag_icache 1
>
> Don't remove it, set it to 0.
The Config.VI probe already reports it correctly, so I left it to the
probe. Would you prefer the constant anyway?
Hunter