Re: [PATCH bpf-next v2 1/5] bpf: Avoid per-CPU private stack in preemptible tracing progs
From: bot+bpf-ci
Date: Wed Nov 11 2026 - 16:09:46 EST
> bpf: Avoid per-CPU private stack in preemptible tracing progs
TL;DR: Selftest nits only: renamed "No private stack" tests in
verifier_private_stack.c keep old "private_stack" function names, and one
comment still describes the old mixed case.
> diff --git a/tools/testing/selftests/bpf/progs/verifier_private_stack.c b/tools/testing/selftests/bpf/progs/verifier_private_stack.c
> --- a/tools/testing/selftests/bpf/progs/verifier_private_stack.c
> +++ b/tools/testing/selftests/bpf/progs/verifier_private_stack.c
[ ... ]
> SEC("raw_tp")
> -__description("Private stack, run, exception in main prog")
> +__description("No private stack, run, exception in main prog")
> __success __retval(1)
> __arch_x86_64
> -__jited(" movq %rdi, -0x200(%r9)")
> -__jited(" movl $0x1, %edi")
> -__jited(" pushq %r9")
> -__jited("...")
> -__jited(" callq")
> +__jited(" subq $0x200, %rsp")
> __naked void private_stack_run_exception_main_prog(void)
> {
this isn't a bug, but would it be clearer to rename
private_stack_run_exception_main_prog() to match its new "No private stack"
description?
The same applies to private_stack_run_exception_sub_prog() and
private_stack_subprog_throw(). Elsewhere in this file the function name
follows the description, for example no_private_stack_kprobe(), and
private_stack_returns() was renamed to big_stack_returns() in
verifier_unwind.c when its description changed.
[ ... ]
> /* Only the frame of the main prog counts, and it has nothing pushed at the call */
> SEC("raw_tp")
> -__description("Private stack, run, exception in subprog, no private stack in main prog")
> +__description("No private stack, run, exception in subprog with a large stack")
> __success __retval(3)
Also, the comment above no_private_stack_run_exception_sub_prog() still
describes the old mixed case, a main prog with nothing pushed at the call.
Now that neither frame has a private stack, should it be dropped or reworded?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/43092697553