Re: [PATCH v3 2/5] clk: cix: Handle Sky1 AUDSS DMA interrupt gates as an irqchip

From: Brian Masney

Date: Wed Nov 11 2026 - 17:18:10 EST


Hi Jelly,

> The AUDSS CRU INFO_AP_IRQC register gates each DMA-350 channel interrupt
> onto the shared AP GIC line. Manage these gates with an irqchip in the
> CRU driver, keeping access to CRU registers out of the DMA driver. Mask
> and unmask the corresponding AP gate through the IRQ core; this controls
> interrupt delivery, not AP/DSP channel ownership.
>
> The register exposes gate state but no per-channel pending status. Poll
> each enabled child's DMA handler to check its channel-local status. Use
> level flow handling so disabled and oneshot-threaded interrupts remain
> masked, and mark the children as polled because IRQ_NONE is expected
> when a different channel caused the parent interrupt.
>
> Use a raw regmap lock for the hard-IRQ callbacks and keep the CRU powered
> while its IRQ resources are in use or being torn down. Quiesce the parent
> IRQ before runtime suspend and move system sleep handling to noirq.
> Save and restore the interrupt gates and software reset state with the
> other CRU context. Dispose of child mappings before removing the domain.
>
> Signed-off-by: Jelly Jia <Jelly.Jia@xxxxxxxxxxx>

The irqchip driver doesn't belong in the clk subsystem, and it needs to
go in the irqchip subsystem. You can use the auxilary device like what's
done for the reset driver today.

Brian

--
Brian Masney <masneyb@xxxxxxxxxx>