Re: [PATCH 1/2] remoteproc: k3: Report a remote crash to the remoteproc core

[Francesco Valla]

On Mon, Nov 09, 2026 at 08:48:29AM +0300, Chrispine Tinega wrote:
> A K3 remote core that faults can send RP_MBOX_CRASH over the mailbox,
> but k3_rproc_mbox_callback() only logs it. The remoteproc core never
> learns of the crash, so its recovery never runs, the crash is not
> counted, and the core stays halted with every rpmsg channel to it dead.
> 
> Call rproc_report_crash(), which may be called from atomic context. The
> core then moves to RPROC_CRASHED and the crash is counted. Where the
> driver leaves recovery enabled, recovery stops the core and boots it
> again. Where recovery is disabled, the core can still be stopped and
> started again through sysfs.
> 
> Signed-off-by: Chrispine Tinega <dev@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/remoteproc/ti_k3_common.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_common.c
> index 4b6da3363..d799f377b 100644
> --- a/drivers/remoteproc/ti_k3_common.c
> +++ b/drivers/remoteproc/ti_k3_common.c
> @@ -60,11 +60,8 @@ void k3_rproc_mbox_callback(struct mbox_client *client, void *data)
>  
>  	switch (msg) {
>  	case RP_MBOX_CRASH:
> -		/*
> -		 * remoteproc detected an exception, but error recovery is not
> -		 * supported. So, just log this for now
> -		 */
>  		dev_err(dev, "K3 rproc %s crashed\n", rproc->name);

Since rproc_report_crash() is already logging the crash detection (also
printing the name of the rproc), maybe this print can be removed?
On the AM67A (MCU R5F remoteproc) the following prints appear on crash:

  [   29.107991] platform 79000000.r5f: K3 rproc 79000000.r5f crashed
  [   29.108025] remoteproc remoteproc2: crash detected in 79000000.r5f: type fatal error
  [   29.108032] remoteproc remoteproc2: handling crash #1 in 79000000.r5f

> +		rproc_report_crash(rproc, RPROC_FATAL_ERROR);
>  		break;
>  	case RP_MBOX_ECHO_REPLY:
>  		dev_info(dev, "received echo reply from %s\n", rproc->name);
> -- 
> 2.53.0
> 
> 

Regards,
Francesco