Re: [PATCH 3/3] pmdomain: rockchip: do not report probe deferral of a domain as an error

From: Sebastian Reichel

Date: Wed Nov 11 2026 - 18:26:12 EST


Hi,

On Tue, Nov 10, 2026 at 07:11:30AM +0000, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@xxxxxxxxx>
>
> When a power domain clock is not available yet,
> rockchip_pm_add_one_domain() records the reason with dev_err_probe() and
> returns -EPROBE_DEFER, but its callers rockchip_pm_domain_probe() and
> rockchip_pm_add_subdomain() still print it with dev_err():
>
> rockchip-pm-domain ...: failed to handle node power-domain: -517
>
> once per probe attempt, and twice for a nested domain. On an RK3588
> board whose NPU domain clock appears late this is more than 20 error
> lines before the domain finally probes.
>
> Only rockchip_pm_add_one_domain() can return -EPROBE_DEFER here, and it
> already records the deferral reason, so skip the message in the callers
> for -EPROBE_DEFER and keep it for real errors. dev_err_probe() is not
> used in the callers because it would replace the reason recorded for
> /sys/kernel/debug/devices_deferred ("failed to get clk at index 1") with
> the less specific "failed to handle node power-domain".
>
> Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver")
> Fixes: 6be05b5ec161 ("soc: rockchip: power-domain: add support for sub-power domains")
> Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
> ---
> drivers/pmdomain/rockchip/pm-domains.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index d7df19e10000..70ebe5696b39 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -1050,8 +1050,9 @@ static int rockchip_pm_add_subdomain(struct rockchip_pmu *pmu,
>
> error = rockchip_pm_add_one_domain(pmu, np);
> if (error) {
> - dev_err(pmu->dev, "failed to handle node %pOFn: %d\n",
> - np, error);
> + if (error != -EPROBE_DEFER)
> + dev_err(pmu->dev, "failed to handle node %pOFn: %d\n",
> + np, error);
> return error;
> }
>
> @@ -1144,15 +1145,17 @@ static int rockchip_pm_domain_probe(struct platform_device *pdev)
> for_each_available_child_of_node_scoped(np, node) {
> error = rockchip_pm_add_one_domain(pmu, node);
> if (error) {
> - dev_err(dev, "failed to handle node %pOFn: %d\n",
> - node, error);
> + if (error != -EPROBE_DEFER)
> + dev_err(dev, "failed to handle node %pOFn: %d\n",
> + node, error);
> goto err_out;
> }
>
> error = rockchip_pm_add_subdomain(pmu, node);
> if (error < 0) {
> - dev_err(dev, "failed to handle subdomain node %pOFn: %d\n",
> - node, error);
> + if (error != -EPROBE_DEFER)
> + dev_err(dev, "failed to handle subdomain node %pOFn: %d\n",
> + node, error);
> goto err_out;
> }
> }

I suggest to fully drop those dev_err() and instead ensure that
rockchip_pm_add_subdomain() has dev_err_probe() in all relevant
error paths. Note that -ENOMEM should also be quiet, so its almost
done already.

-- Sebastian

Attachment: signature.asc
Description: PGP signature