[PATCH v2 00/22] Squashfs: fix a lot of AI issues and AI style issues
From: Phillip Lougher
Date: Wed Nov 11 2026 - 18:46:23 EST
This large patch-set is inspired by the recent spate of AI generated
code reports. Four of the patches directly fix AI reported issues, and
the rest have been found manually by a read-through and testing of the
code.
In all cases (except patches 17, 18 and 19) the patches deal with
over-sights relating to variable overflow, arithmetic overflow, variable
signedness or just lack of sanity checking of data read from disk.
These can cause the code to fail, and which could be used as a potential
exploit.
Patches 17, 18, and 19 fix potential excessive memory use exploits. The
code in question was written in the early days when Squashfs filesystems
were small, but with very large filesystems it could try to allocate
memory in excess of 4 MiB, and up to 64 MiB.
The patches can be broken down as follows:
Patches 1 - 6 are preparatory patches. They convert old fashioned
#define macros into inline functions. These being typed make widths and
signedness explicit, and allow additional checking to be added in later
patches.
Patch 7 fixes an incorrect offset value in TRACE statements in
squashfs_read_inode(). This new to this V2 patch-set.
Patches 8 - 16 fix various issues relating to variable overflow,
arithmetic overflow and add additional sanity checking to prevent these
issues from occurring.
Patches 17 - 19 remove the excessive allocation of memory by introducing
caches, which limit the maximum usage to 4 pages.
Patches 20 - 21 are new to this V2 patch-set. They deal with some
issues Sashiko reported in the original patch-set.
Patch 22 is also new to this V2 patch-set. It adds an additional belts
and braces sanity check.
Patches 8 - 20 have reproducers which show how the existing code faults
can be exploited, in some cases which can allow a Squashfs filesystem
to be tampered with to make files readable by unprivileged users.
BTW checkpatch.pl complains about the '#' lines in the BASH script
reproducers. Let me know if that will cause problems.
fs/squashfs/block.c | 20 ++-
fs/squashfs/cache.c | 8 +-
fs/squashfs/dir.c | 91 ++++++++---
fs/squashfs/export.c | 146 ++++++++++++-----
fs/squashfs/file.c | 89 ++++++----
fs/squashfs/fragment.c | 113 ++++++++++---
fs/squashfs/id.c | 9 +-
fs/squashfs/inode.c | 73 +++++----
fs/squashfs/namei.c | 116 +++++++++----
fs/squashfs/squashfs.h | 9 +-
fs/squashfs/squashfs_fs.h | 101 ------------
fs/squashfs/squashfs_fs_i.h | 2 +-
fs/squashfs/squashfs_fs_sb.h | 25 ++-
fs/squashfs/squashfs_helpers.h | 363 +++++++++++++++++++++++++++++++++++++++++
fs/squashfs/super.c | 96 +++++++----
fs/squashfs/xattr.c | 49 ++++--
fs/squashfs/xattr.h | 21 ++-
fs/squashfs/xattr_id.c | 173 ++++++++++++++------
18 files changed, 1099 insertions(+), 405 deletions(-)
Phillip
---
Squashfs maintainer and author