Re: [PATCH v3 next 04/13] scripts/kallsyms: make use of binary data output optional
From: bot+bpf-ci
Date: Wed Nov 11 2026 - 18:50:34 EST
> scripts/kallsyms: make use of binary data output optional
TL;DR: Nits only: possibly unneeded sys/stat.h include in kallsyms.c, commit
message typos and commit reference format, and a question whether independent
changes should be split into separate patches.
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
[ ... ]
> @@ -278,26 +283,16 @@ static void add_table_entry(struct sym_entry *sym)
> table[table_cnt++] = sym;
> }
>
> -static bool file_is_empty(const char *path)
> -{
> - struct stat st;
> -
> - if (stat(path, &st))
> - err(EXIT_FAILURE, "stat(%s) failed", path);
> -
> - return st.st_size == 0;
> -}
> -
this isn't a bug, but with file_is_empty() gone, is #include <sys/stat.h>
still needed in kallsyms.c, or can it be dropped in the same change?
[ ... ]
Commit message:
> While writing some of the output in binary (and using the .incbin directive
> to get the assembler to read it) speeds up normal kernel builds, it makes
> debugging kallsyms almost impossible.
> Change the command line processing so that the out.bin file is optional,
> if absent everything is written to out.S (at is was prior to 83da9f3197e5).
> [ ... ]
> To help anyone who ends up looking an hexdump of out.bin, add a text header
> and 16 byte align each table.
this isn't a bug, but there are typos here: "at is was" and "looking an
hexdump". Should the reference to 83da9f3197e5 also be given in the usual
form with the subject, e.g. ("kallsyms: output binary data to speed output
and kallsyms assembly")?
Also, could the independent parts (the hexdump headers and alignment, the
fwrite() offsets fast path, the token table reordering) go in separate
patches? They don't appear to depend on making out.bin optional.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/43116767394