Re: [PATCH v2 4/4] clk-816x: add sys_ck clock as sys_clkin_ck alias
From: Ettore Chimenti
Date: Wed Nov 11 2026 - 19:04:42 EST
Hi Brian,
On Wed Nov 11, 2026 at 7:53 PM CET, Brian Masney wrote:
> Hi Ettore,
>
> On 2026-10-30 11:48:58+01:00, Ettore Chimenti wrote:
>> On Wed Oct 28, 2026 at 4:53 PM CET, Ettore Chimenti wrote:
>>
>> > This patch adds a new clock alias for the DM816x system, mapping
>> > 'sys_ck' to 'sys_clkin_ck'. This change is necessary because the voltage
>> > management driver searches for 'sys_ck' in these systems and fails
>> > without this alias. By including 'sys_ck' as an alias for
>> > 'sys_clkin_ck', we ensure compatibility with existing drivers that may
>> > reference 'sys_ck'.
>> >
>> > Tested-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
>> > Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
>> > ---
>> > drivers/clk/ti/clk-816x.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/clk/ti/clk-816x.c b/drivers/clk/ti/clk-816x.c
>> > index 3b8e483aec92..fe6f66fc5a05 100644
>> > --- a/drivers/clk/ti/clk-816x.c
>> > +++ b/drivers/clk/ti/clk-816x.c
>> > @@ -57,6 +57,7 @@ static struct ti_dt_clk dm816x_clks[] = {
>> > DT_CLK(NULL, "timer_sys_ck", "sys_clkin_ck"),
>> > DT_CLK(NULL, "timer_32k_ck", "sysclk18_ck"),
>> > DT_CLK(NULL, "timer_ext_ck", "tclkin_ck"),
>> > + DT_CLK(NULL, "sys_ck", "sys_clkin_ck"),
>> > { .node_name = NULL },
>> > };
>>
>> I'll drop this patch from the series. The proposed approach from Sashiko
>> seems sound and I just sent a separate patch that implements that.
>
> Will there be a follow up to this series for the clk subsystem? I don't
> see any. I haven't gone through the other patches in this series. Or are
> just the first 3 patches here what needs to be reviewed / possibly
> merged?
Actually, I was waiting for reviews on the other patches before sending
a v3 to collect R-b's.
However, this patch (4/4) can be skipped reviewing. It will be dropped
as I've already sent [1] (it belongs to another subsystem, so you might
have missed it).
[1]: https://lore.kernel.org/all/20261030-patch-ektor5-dm81xx-vd-v1-1-8ba90608c25b@xxxxxxxxxx/
>
> Brian
Thanks,
Ettore