Re: [PATCH net-next v6 RESEND 3/4] net: stmmac: release descriptor resources through priv->dma_conf on open failure
From: Jakub Kicinski
Date: Wed Nov 11 2026 - 19:40:42 EST
On Fri, 6 Nov 2026 17:05:05 +0800 Ding Hui wrote:
> __stmmac_open() copies the temporary dma_conf passed by its callers
> into the long-lived priv->dma_conf before setting up the hardware.
> When the open fails after this copy, the descriptor resources now
> belong to priv->dma_conf, but the error path returns without
> releasing them and leaves stale pointers behind. The callers then
> free the already-copied resources through the temporary dma_conf,
> which aliases priv->dma_conf after the memcpy.
This patch is not sufficient, as AI points out.
The duplicated error path on failure of __stmmac_open() indicates
the state transitions need a lot of work.
We need someone who knows what they're doing to look at it.
You can't even read what the series info bot is asking you.
Please *DO NOT* send any more patches for stmmac.