Re: [PATCH v5 6/6] agents: add a skill to write KUnit tests

From: Andrew Morton

Date: Wed Nov 11 2026 - 20:13:28 EST


On Wed, 11 Nov 2026 17:59:38 -0500 "Theodore Ts'o" <tytso@xxxxxxx> wrote:

> Add a skill under agents/skills/writing-kunit-tests/ to guide coding
> assistants when designing, implementing, verifying, or reviewing KUnit
> unit tests. Point the skill at the KUnit and process documentation and
> cover unit testing principles (testing behaviors rather than
> implementation details, keeping tests focused and DAMP, choosing
> non-default and distinct test values, using narrow expectations, and
> maintaining test isolation), KUnit resource management and static stub
> idioms, and verification with kunit.py.
>
> Update Documentation/process/coding-assistants.rst to list the new skill
> and note that skills only inspect and report unless their task is to
> write or modify code or tests.
>
> ...
>
> + KUNIT_DEFINE_ACTION_WRAPPER(my_resource_cleanup, my_resource_cleanup_wrapper,
> + struct my_resource *);

LLM says this should be

KUNIT_DEFINE_ACTION_WRAPPER(my_resource_cleanup_wrapper, my_resource_cleanup, struct my_resource *)

:)