Re: [PATCH v2 00/33] HID: logitech-hidpp: G920 force-feedback fixes, rework, and cleanups

From: Gideon Heinz

Date: Wed Nov 11 2026 - 20:43:21 EST


Hi Dmitry,

I tested v2 of the series on my G920 (046d:c262). Everything on my
list works except one scenario that takes the whole machine down, with
and without your series (last item).

Setup: Linux 7.3.1-1-cachyos (clang build). The pre-image of patch 1
(blob 60fc6b86a085) is identical to v7.4-rc2's hid-logitech-hidpp.c, so
I applied all 33 patches to that file (every step matched the blob hash
recorded in the patch) and built it as an out-of-tree module against
the 7.3.1 headers, loaded with insmod. The only local change is a
3-line fallback for devm_kzalloc_obj(), which the 7.3.1 headers lack.
No full kernel build.

Results:

- Initialization: "Force feedback support loaded (firmware release 4)"
on every plug-in (8 in total), no -110.

- fftest: all effect types are listed and the effects play and
produce force. After exiting with -1 the log stays clean for 2+
minutes.

- Input: wheel rotation, buttons and the hat all register in evtest.
I use other pedals, so the G920 pedals are untested.

- range sysfs: with nothing holding the device open, writes take
~67 ms and read back correctly (540, then 900). On v1 my
closed-device writes each ended in a "Failed to send command to
device!" about 15 s later. With evtest open it behaves the same.
100 reads back as 180 and 2000 as 900.

- Replug x4: FF loads cleanly each time.

- Unplug with evtest open: evtest exits with "No such device",
"Unloading HID++ force feedback" and nothing else in dmesg.

- Unplug with fftest open (6 effects loaded): 6 "Failed to send
command to device!" lines within 1.7 ms of each other (v1 gave 12),
then "Unloading HID++ force feedback" 19 ms after the last. No
warnings, oops or hangs.

- rmmod with fftest holding the device open: rmmod returned after
2.99 s with "Unloading HID++ force feedback" and nothing else in
dmesg. When I then exited fftest (entering -1), the machine went
down: the first time with a garbled panic screen that I couldn't
read, and on later attempts as a total hang with no output. The
same sequence on stock Arch 7.2.11-arch1-1 with the unpatched
driver also hangs the whole system, so this predates the series.

To reproduce: with the module loaded and the G920 plugged in, start
fftest on its event node and leave it at the effect prompt, run
"rmmod hid_logitech_hidpp" from another terminal, then enter -1 in
fftest.

I could not recover a trace yet and will send one if I manage to.

My guess, from reading the code and not verified by a trace:
hidpp_ff_create() stores hidpp_ff_destroy() and the other FF
callbacks in the ff_device as pointers into the module. With fftest
holding the evdev open, the input_dev outlives the driver, so when
fftest closes, the final input_dev release calls ff->destroy in
module code that rmmod has already freed.

Not tested: the battery patches (10-14, a wired G920 can't exercise
them), in-game FFB, and sysfs driver unbind.

Happy to test patches or send the full logs.

Gideon