Re: [PATCH] net: mark skb NAPI IDs independently of busy polling

From: Ding Meng

Date: Wed Nov 11 2026 - 23:35:21 EST


On Tue, Nov 10, 2026 at 01:45:39PM -0800, Jakub Kicinski wrote:
> On Thu, 5 Nov 2026 15:16:08 +0800 Ding Meng wrote:
> > + interface index will be returned only if CONFIG_SKB_MARK_NAPI_ID is
> > + enabled and the driver is using NAPI. This hidden configuration is
> > + selected automatically by busy-poll support and by drivers that need
> > + skb NAPI IDs to resolve deferred hardware timestamps. Drivers that
> > + use deferred timestamp conversion must select it so the networking
> > + stack can find the device and call its timestamp callback even when
> > + busy polling is disabled. The struct contains also two other fields,
> > + but they are reserved and undefined.
>
> Just take napi_id from under CONFIG_NET_RX_BUSY_POLL instead of
> complicating everyone's lives.
> --
> pw-bot: cr

When BUSY_POLL is n under PREEMPT_RT && NETCONSOLE, igc fails to get RX
hardware timestamps.

Then, drivers that use deferred timestamp conversion (e.g. igc, engleder) must
specify a busy poll dependency if they want to obtain the original net
device upon consuming the skb. However, this dependency is far from
obvious, and annotating it for future features of this kind will be very
hard to discover.

Configuring the skb napi ID separately
from busy poll seems cleaner and more reasonable.