Re: [PATCH] soundwire: mipi_disco: Put fwnode on property array read errors

From: Xiangwu Lai

Date: Thu Nov 12 2026 - 01:09:06 EST


Hi,

thanks for the review.

Both Fixes tag corrections are right: the subject uses "mipi-disco",
and the lane-list error paths (including the -ENOMEM one, which was
missing the put unlike its siblings) were introduced by 71b405b18444.
v2 carries both Fixes tags and mentions the -ENOMEM fix explicitly.

The clock sysfs buffer overflow is also real: prop->num_clk_freq and
prop->num_clk_gears are taken from firmware-supplied properties
without an upper bound, and the show callbacks use unbounded
sprintf(). It is already being addressed by an in-flight patch from
Weigang He, so I did not duplicate it:

https://lore.kernel.org/all/20260926042935.2284011-1-geoffreyhe2@xxxxxxxxx/

v2 follows shortly.

Best regards,
Xiangwu Lai