[PATCH] power: supply: max77705: Propagate battery health read errors

From: Zhu Jun

Date: Thu Nov 12 2026 - 02:25:07 EST


max77705_get_battery_health() decodes bat_dtls even when the register
read fails. The helper then returns success and can report a battery
health state derived from an uninitialized value.

Check the read result before decoding the battery status. The existing
health and property callbacks already propagate the helper's error.

Fixes: a6a494c8e3ce ("power: supply: max77705: Add charger driver for Maxim 77705")
Signed-off-by: Zhu Jun <zhujun2@xxxxxxxxxxxxxxxxxxxx>
---
drivers/power/supply/max77705_charger.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/max77705_charger.c b/drivers/power/supply/max77705_charger.c
index ca9ad041f1ed..f9878358e53d 100644
--- a/drivers/power/supply/max77705_charger.c
+++ b/drivers/power/supply/max77705_charger.c
@@ -278,8 +278,11 @@ static int max77705_get_battery_health(struct max77705_charger_data *chg,
{
struct regmap *regmap = chg->regmap;
unsigned int bat_dtls;
+ int ret;

- regmap_read(regmap, MAX77705_CHG_REG_DETAILS_01, &bat_dtls);
+ ret = regmap_read(regmap, MAX77705_CHG_REG_DETAILS_01, &bat_dtls);
+ if (ret)
+ return ret;
bat_dtls = ((bat_dtls & MAX77705_BAT_DTLS) >> MAX77705_BAT_DTLS_SHIFT);

switch (bat_dtls) {
--
2.51.0