Re: [PATCH 02/20 v3] sched/eevdf: Reset lag at wakeup when prev CPU has been idle
From: Vincent Guittot
Date: Thu Nov 12 2026 - 02:57:50 EST
On Wed, 11 Nov 2026 at 11:04, K Prateek Nayak <kprateek.nayak@xxxxxxx> wrote:
>
> Hello Vincent,
>
> On 11/6/2026 8:49 PM, Vincent Guittot wrote:
> > @@ -8376,6 +8383,9 @@ static bool __dequeue_task(struct rq *rq, struct task_struct *p, int flags)
> >
> > dequeue_hierarchy(p, flags);
> >
> > + if (!(flags & DEQUEUE_SAVE) && !cfs_rq->h_nr_queued)
>
> Should this also consider DEQUEUE_CLASS which will move the task out
> of fair class and leave the rq idle? setscheduler just adds it with
> DEQUEUE_SAVE when moving classes.
Yes you're right, we have to update idle_seq when
DEQUEUE_SLEEP or DEQUEUE_CLASS
>
> > + cfs_rq->idle_seq++;
> > +
> > if (sched_feat(PLACE_REL_DEADLINE) && !task_sleep) {
> > se->deadline -= se->vruntime;
> > se->rel_deadline = 1;
>
> --
> Thanks and Regards,
> Prateek
>