Re: [PATCH v2] gpio: shared: fix a race in shared desc release path
From: Bartosz Golaszewski
Date: Thu Nov 12 2026 - 03:41:05 EST
On Tue, 10 Nov 2026 11:10:40 +0100, Bartosz Golaszewski wrote:
> gpiod_shared_put() races with concurrent calls to
> devm_gpiod_shared_get() like so:
>
> CPU 0 (unbind / probe failure) CPU 1 (concurrent proxy probe)
> ============================== ==============================
> gpiod_shared_put()
> kref_put(&entry->ref, ...)
> refcount_dec_and_test() // -> 0
> devm_gpiod_shared_get()
> mutex_lock(&entry->lock);
> if (entry->shared_desc) {
> kref_get(&entry->ref); // on 0!
> shared_desc = entry->shared_desc;
> }
> mutex_unlock(&entry->lock);
> gpio_shared_release()
> mutex_lock(&entry->lock);
> kfree(shared_desc);
> entry->shared_desc = NULL;
> mutex_unlock(&entry->lock);
> // uses freed shared_desc
>
> [...]
Applied, thanks!
[1/1] gpio: shared: fix a race in shared desc release path
https://git.kernel.org/brgl/c/53043b9e83cc7f4e30e70161b67ae93c4c9fdb87
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>