Re: [PATCH v3 0/2] Update handling of min and max channel in DisCo

From: Pierre-Louis Bossart

Date: Thu Nov 12 2026 - 03:45:21 EST


On 11/11/26 17:24, Charles Keepax wrote:
> The DisCo properties "mipi-sdw-min-channel-number" and
> "mipi-sdw-max-channel-number" are both channel indexes rather than
> counts. Update the kernel code to more accurately reflect this.
>
> There are a few Qualcomm drivers that likely specify these incorrect,
> min_ch=1, max_ch=X, rather than min_ch=0, max_ch=X-1, however these
> should work fine as the number of supported channels is equivalent.
> If people feel strongly I can send another series to fix those up.
>
> Changes since v2:
> - Moved the parsing of min/max channels to only be processed if
> num_channels is missing
>
> Changes since v1:
> - Update wording on min_ch/max_ch comments
>
> Charles Keepax (2):
> soundwire: Improve channel min/max comments
> soundwire: Assume default maximum valid channel if not specified
>
> drivers/soundwire/mipi_disco.c | 14 ++++++++------
> include/linux/soundwire/sdw.h | 4 ++--
> 2 files changed, 10 insertions(+), 8 deletions(-)

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>