Re: [PATCH 04/13] kprobes: Maintain an rbtree of registered probes
From: Peter Zijlstra
Date: Thu Nov 12 2026 - 04:04:17 EST
On Mon, Nov 09, 2026 at 08:55:17PM +0100, Jiri Olsa wrote:
> +static void kprobe_tree_insert(struct kprobe *p)
> +{
> + struct rb_node **link = &kprobe_tree.rb_node, *parent = NULL;
> + unsigned long addr = (unsigned long)p->addr;
> +
> + lockdep_assert_held(&kprobe_mutex);
> + while (*link) {
> + struct kprobe *kp = rb_entry(*link, struct kprobe, rb_node);
> + unsigned long kp_addr = (unsigned long)kp->addr;
> +
> + parent = *link;
> + if (addr < kp_addr)
> + link = &(*link)->rb_left;
> + else if (addr > kp_addr)
> + link = &(*link)->rb_right;
> + else {
> + WARN_ON_ONCE(1);
> + return;
> + }
> + }
> +
> + rb_link_node(&p->rb_node, parent, link);
> + rb_insert_color(&p->rb_node, &kprobe_tree);
> +}
You probably want to use rb_add() here.