Re: [PATCH 1/4] dt-bindings: soc: introduce toshiba,tc9564-config-syscon.yaml
From: Krzysztof Kozlowski
Date: Thu Nov 12 2026 - 04:18:40 EST
On 04/11/2026 01:43, Alex Elder wrote:
> Define the binding for the system controller that implements the clock
> and reset controller functionality present in the Toshiba TC9564 SoC.
>
> Co-developed-by: Daniel Thompson <daniel@xxxxxxxxxxxx>
> Signed-off-by: Daniel Thompson <daniel@xxxxxxxxxxxx>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
> ---
> .../toshiba/toshiba,tc9564-config-syscon.yaml | 68 +++++++++++++++++++
> MAINTAINERS | 8 +++
> include/dt-bindings/soc/toshiba,tc9564.h | 46 +++++++++++++
> 3 files changed, 122 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
> create mode 100644 include/dt-bindings/soc/toshiba,tc9564.h
>
> diff --git a/Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml b/Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
> new file mode 100644
> index 0000000000000..5a241a9c915d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
Additionally, if this binding somehow goes further, this cannot go to
soc directory. This is not a SoC in this context and "soc" directory is
not a dumping ground for things you don't know where to put.
...
> TOSHIBA WMI HOTKEYS DRIVER
> M: Azael Avalos <coproscefalo@xxxxxxxxx>
> L: platform-driver-x86@xxxxxxxxxxxxxxx
> diff --git a/include/dt-bindings/soc/toshiba,tc9564.h b/include/dt-bindings/soc/toshiba,tc9564.h
> new file mode 100644
> index 0000000000000..66bcdf837f958
> --- /dev/null
> +++ b/include/dt-bindings/soc/toshiba,tc9564.h
Neither this. If you have clock controller, then header goes to clock.
Soc directory is ONLY for a very small subset of SoC driver ABI, which
you do not have here.
> @@ -0,0 +1,46 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
Best regards,
Krzysztof