Re: [PATCH net] udp_tunnel: don't treat IPv4 sockets bound to an address as wildcard

[Antonio Quartulli]

On 12/11/2026 07:02, Kuniyuki Iwashima wrote:
> > diff --git a/net/ipv4/udp_tunnel_core.c b/net/ipv4/udp_tunnel_core.c
> > index a128fe85620d..29581c94fdcf 100644
> > --- a/net/ipv4/udp_tunnel_core.c
> > +++ b/net/ipv4/udp_tunnel_core.c
> > @@ -62,10 +62,10 @@ EXPORT_SYMBOL(udp_sock_create4);
> >   static bool sk_saddr_any(struct sock *sk)
> >   {
> >   #if IS_ENABLED(CONFIG_IPV6)
> > -	return ipv6_addr_any(&sk->sk_v6_rcv_saddr);
> > -#else
> > -	return !sk->sk_rcv_saddr;
> > +	if (sk->sk_family == AF_INET6)
> > +		return ipv6_addr_any(&sk->sk_v6_rcv_saddr);
> >   #endif
> > +	return !sk->sk_rcv_saddr;
>
> This is identical with inet_rcv_saddr_any().  As a follow-up
> in net-next, please move sk_saddr_any() to include/net/sock.h
> and use it everywhere.

Yes, indeed.
Ok, I'll add it to my todo list.

> Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

Thanks!


--
Antonio Quartulli

CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com