[PATCH v2 03/11] drm/panfrost: Don't take a reference on a mapping that is being freed

From: Arun Iyengar via B4 Relay

Date: Thu Nov 12 2026 - 04:22:39 EST


From: Arun Iyengar <aiyengar1990@xxxxxxxxx>

addr_to_mapping() looks up the mapping that contains a faulting GPU
address in the address space's drm_mm and takes a reference on it with
kref_get(). But panfrost_gem_mapping_put() drops the last reference
before panfrost_gem_mapping_release() -> panfrost_gem_teardown_mapping()
unmaps the BO and removes its node from the drm_mm under mm_lock, so the
lookup can find a mapping whose refcount is already zero. kref_get()
then revives it (refcount_t warns about the addition on zero), the
release goes on and frees the mapping and drops the BO, and the fault
handler maps pages into a BO that is being freed.

This takes a GPU fault on a heap BO's address while the last handle and
the last job reference to that BO go away. Jobs hold a reference on the
mappings of the BOs they list, so it takes a job that uses a heap BO it
does not list; userspace on the render node can submit that.

Use kref_get_unless_zero() and treat a mapping that is being freed as
absent: the fault is then reported as unhandled.

Found by code review: the same pattern in new code of this series was
reported by Sashiko. Not reproduced.

Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/all/sashiko-outbox-206570@xxxxxxxxxx/
Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
---
drivers/gpu/drm/panfrost/panfrost_mmu.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
index faa62643c..eaf94d47d 100644
--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -576,7 +576,13 @@ addr_to_mapping(struct panfrost_device *pfdev, int as, u64 addr)
offset < (node->start + node->size)) {
mapping = drm_mm_node_to_panfrost_mapping(node);

- kref_get(&mapping->refcount);
+ /* The last reference to a mapping is dropped before
+ * panfrost_gem_teardown_mapping() takes its node out
+ * of the address space: don't revive one that is
+ * being freed.
+ */
+ if (!kref_get_unless_zero(&mapping->refcount))
+ mapping = NULL;
break;
}
}

--
2.55.0