Re: [PATCH v2 6/8] spi: dt-bindings: cdns,xspi: add ADI SC846 compatible
From: Nuno Sá
Date: Thu Nov 12 2026 - 04:48:37 EST
On Thu, Nov 12, 2026 at 09:32:36AM +0000, Nuno Sá wrote:
> On Wed, Nov 11, 2026 at 05:58:09PM +0000, Conor Dooley wrote:
> > On Wed, Nov 11, 2026 at 01:23:07PM +0000, Nuno Sá wrote:
> > > The Analog Devices ADSP-SC846 SoC integrates the Cadence xSPI controller
> > > with its own PHY timing configuration and with the support needed for
> > > the auto command (ACMD) mode with the internal DMA, so it cannot be
> > > described by the generic "cdns,xspi-nor" compatible. Add a SoC specific
> > > compatible for it.
> >
> > I assume it's the phy timing that means the cdns,xspi-nor compatible
> > cannot be used as a fallback?
>
> Exactly. Without proper phy settings we cannot probe the memory chips.
> There are some works being done to support phy tuning but even when
> that lands, not sure how generic it could be supported.
>
> Hmm, I guess you want the above mentioned in the commit right?
Nevermind, it's already in there.
>
> - Nuno Sá
>
> >
> > >
> > > On this SoC, the controller clock and reset are always wired, so make
> > > them required.
> > >
> > > Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > > ---
> > > Documentation/devicetree/bindings/spi/cdns,xspi.yaml | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > > index 3cd7321319bb..d6ac05b2efb4 100644
> > > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > > @@ -18,6 +18,7 @@ description: |
> > > properties:
> > > compatible:
> > > enum:
> > > + - adi,adsp-sc846-xspi
> > > - cdns,xspi-nor
> > > - marvell,cn10-xspi-nor
> > >
> > > @@ -53,6 +54,15 @@ required:
> > >
> > > allOf:
> > > - $ref: spi-controller.yaml#
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + const: adi,adsp-sc846-xspi
> > > + then:
> > > + required:
> > > + - clocks
> > > + - resets
> > > - if:
> > > properties:
> > > compatible:
> > >
> > > --
> > > 2.56.0
> > >
>
>