Re: [PATCH v2] ASoC: Intel: Remove unused intel-sst.h trace header
From: Cezary Rojewski
Date: Thu Nov 12 2026 - 05:03:34 EST
On 11/11/2026 11:31 PM, Temitope obabi wrote:
> Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed
> sound/soc/intel/common/sst-dsp.c, the only file that defined
> CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
>
> Nothing includes this header anymore, so none of its tracepoints are
> built. Remove the unused header.
>
> Signed-off-by: Temitope obabi <obabitemitope765@xxxxxxxxx>
> ---
> Changes in v2:
> - Remove the whole header instead of only sst_ipc_inbox_rdata, since
> nothing includes it (reported by the Sashiko review of v1).
> - Drop the Fixes tag and the claim about memory used per tracepoint.
> - This also replaces the earlier sst_ipc_msg_tx patch for the same header.
Next time, please CC sound/soc/intel maintainers. The very commit starts
with "ASoC: Intel:".
Nitpick: if trace-subsystem maintainers permit ASoC-scoping for
include/trace, please update the title to: "ASoC: Intel: atom:" to
highlight which driver it does relate to.
The nitpick alone is not a reason for re-send.
Acked-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>