Re: [PATCH 1/2] dt-bindings: crypto: Adjust Shikra compatible hierarchy

[Kuldeep Singh]

On 16-10-2026 17:40, Kuldeep Singh wrote:
> On 13-10-2026 12:14, Krzysztof Kozlowski wrote:
>> On Tue, Oct 06, 2026 at 04:44:03PM +0530, Kuldeep Singh wrote:
>>> Shikra reuses the same QCE integration as Agatti and should follow the
>>
>> `git grep Agatti` gives zero.
> 
> Agatti is chipset name and compatible name is "qcom,qcm2290-qce".
> Maybe I'll mention both next time.
> 
>>
>>> corresponding binding requirements too.
>>>
>>> Move the Shikra compatible to the appropriate binding hierarchy
>>> (matching qcom,qcm2290-qce) to reflect the underlying hardware
>>> description.
>>
>> You do not change any binding hierarchy. You are changing fallback
>> compatible which is ABI break without any reason.
> 
> Agatti and shikra both consume RPMCC managed clocks and clk-smd-rpm.c
> does proxy clocks voting as of now even when no consumer is voting for
> it. The required consumer i.e QCE need to vote for it explicitly as
> proxy voting being dropped now in patch [1].
> 
> As agatti(qcom,qcm2290-qce) specifies explicit clock entry as per the
> spec[2] and shikra is derivative of agatti hence, follow the same
> convention.
> 
> Coming to updating fallback compatible introducing ABI break,
> "qcom,shikra-qce" compatible in bindings got accepted in v7.3[3] but not
> the corresponding DTS change[4](which consume this compatible), the DTS
> change is queued for v7.4[5].
> 
> So we can straightaway update the hierarchy then?

I was away on vacation for more than 2weeks and hence couldn't catchup
on the thread. Sorry for delayed response.

Krzysztof, So we can update hierarchy directly right?
Let me send v2 with your prior suggestions.

-- 
Regards
Kuldeep