Re: [RFC PATCH 00/39] sysctl: replace overloaded extra pointers with typed bounds and context

From: Joel Granados

Date: Thu Nov 12 2026 - 05:24:52 EST


On Thu, Oct 29, 2026 at 12:34:39AM +0800, wen.yang@xxxxxxxxx wrote:
> From: Wen Yang <wen.yang@xxxxxxxxx>
>
> struct ctl_table describes an entry with data, maxlen and, until this
> series, two untyped misc pointers in extra1 and extra2. Those two pointers
> have accumulated at least seven unrelated jobs: a fixed bound, a bound read
> through a pointer on every call, an object or namespace pointer, a small
> integer cookie encoded into the pointer, a lock signal, NULL standing for
> "no bound", and a value the core itself casts to unsigned int while
> validating a u8 range. Nothing in the entry says which job applies, so
> readers infer it from the handler, and the core gets it wrong where it
> treats extra1 as an unsigned int.
>
> The numeric half of this change is the direction Eric Biederman asked for:
<... snip ...>
>
> net/ipv6/ndisc.c | 3 +-
> net/ipv6/netfilter/nf_conntrack_reasm.c | 30 +-
> net/ipv6/reassembly.c | 30 +-
> net/ipv6/route.c | 11 +-
> net/ipv6/sysctl_net_ipv6.c | 53 +-
> net/mpls/af_mpls.c | 58 +-
> net/mptcp/ctrl.c | 29 +-
> net/netfilter/ipvs/ip_vs_ctl.c | 157 +-
> net/netfilter/nf_conntrack_standalone.c | 45 +-
> net/netfilter/nf_hooks_lwtunnel.c | 4 +-
> net/netfilter/nf_log.c | 67 +-
> net/phonet/sysctl.c | 6 +-
> net/rds/ib_sysctl.c | 23 +-
> net/rds/sysctl.c | 32 +-
> net/rds/tcp.c | 11 +-
> net/rxrpc/sysctl.c | 51 +-
> net/sctp/sysctl.c | 148 +-
> net/smc/smc_sysctl.c | 42 +-
> net/sunrpc/xprtrdma/svc_rdma.c | 39 +-
> net/sunrpc/xprtrdma/transport.c | 27 +-
> net/sunrpc/xprtsock.c | 26 +-
> net/tipc/sysctl.c | 18 +-
> net/vmw_vsock/af_vsock.c | 4 +-
> net/x25/sysctl_net_x25.c | 23 +-
> security/keys/sysctl.c | 25 +-
> security/loadpin/loadpin.c | 4 +-
> security/yama/yama_lsm.c | 10 +-
> 134 files changed, 3075 insertions(+), 1525 deletions(-)
>
> --
> 2.25.1
>

Hey Wen

What is the base of this series?

And please add a base for your future series.

Best

Attachment: signature.asc
Description: PGP signature