Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
From: Łukasz Majewski
Date: Thu Nov 12 2026 - 05:30:10 EST
Hi Rob,
> On Wed, Nov 11, 2026 at 09:23:11AM +0100, Łukasz Majewski wrote:
> > Hi Guenter,
> >
> > > On 11/10/26 07:02, Lukasz Majewski wrote:
> > > > Add "national,lm77" as compatible for the National (now TI) LM77
> > > > digital I2C temperature sensor.
> > > >
> > > > Signed-off-by: Lukasz Majewski <lukma@xxxxxxxxxxxx>
> > > > ---
> > > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > > 1 file changed, 2 insertions(+)
>
> Not really a trivial device as there is a T_CRIT_A signal...
>
> Though I guess LM80 and probably others aren't really either.
>
Yes...
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > a8b2b9deade4..9413ee0626f5 100644 ---
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > -387,6 +387,8 @@ properties:
> > > > - national,lm85c
> > > > # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature
> > > > Sensor and Thermal Window Comparator
> > > > - national,lm92
> > > > + # Temperature sensor
> > > > + - national,lm77
> > >
> > > I'd suggest to retain alphabetic order.
> > >
> >
> > The "alphabetic" order for "national," is already "disturbed" in
> > this file - that is why I've put it in the end.
> >
> > Now, the question - shall I "order" properly all of "national,"
> > bindings in a single patch (including the new one)?
> >
> > Or prepare two patches:
> > - One to make the alphabetic order for already in-tree properties
> >
> > and
> >
> > - Add the "national,lm77" afterwards ?
>
> Just don't make things worse.
Ok. I will :-)
> Put it after national,lm95245 and
> before national,lm80. Then all but the first 2 are in order.
>
+1
> Rob
--
Best regards,
Lukasz Majewski
--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@xxxxxxxxxxxx
Managing Director : Stefano Babic