Re: [PATCH v2 2/6] media: verisilicon: Don't hold the VPU in reset after remove
From: Philipp Zabel
Date: Thu Nov 12 2026 - 05:51:07 EST
On Do, 2026-11-12 at 08:30 +0000, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@xxxxxxxxx>
>
> On the RK3588, the resets of the AV1 decoder include the AXI and APB
> bus interface resets (SRST_A_AV1_BIU, SRST_P_AV1_BIU), which also cover
> the Verisilicon IOMMU of the decoder. When the driver is unbound, the
> driver core runtime resumes the device and, through the runtime PM
> device link, its IOMMU. hantro_remove() then asserts the resets, and
> when the IOMMU autosuspends 100 ms later, vsi_iommu_suspend() writes to
> its registers while they are held in reset, which raises an SError and
> panics the system:
If vsi-iommu accesses require these bus interface resets to be
deasserted at certain points, why doesn't it request its own reset
controls?
Depending on implicit assumptions like another driver not asserting its
exclusively controlled resets seems fragile.
regards
Philipp