Re: [PATCH 2/2] phy: exynos5-usbdrd: Add support for the Exynos5515 usbdrd phy

From: Vinod Koul

Date: Thu Nov 12 2026 - 06:13:17 EST


On 22-10-26, 17:46, Aiden Isik via B4 Relay wrote:
> From: Aiden Isik <aidenisik@xxxxxxxxxxxxxx>
>
> The Exynos5515 USBDRD PHY is a USB PHY which supports USB Super-Speed
> and High-Speed. Add support for High-Speed (UTMI+) operation.
>
> Signed-off-by: Aiden Isik <aidenisik@xxxxxxxxxxxxxx>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 43 ++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index f10cf7b6e0aa..8718e8f01e46 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -2075,6 +2075,46 @@ static const struct exynos5_usbdrd_phy_drvdata exynos5433_usbdrd_phy = {
> .n_regulators = ARRAY_SIZE(exynos5_regulator_names),
> };
>
> +static const struct exynos5_usbdrd_phy_tuning exynos5515_tunes_utmi_postinit[] = {
> + PHY_TUNING_ENTRY_PHY(EXYNOS850_DRD_HSPPARACON,
> + (HSPPARACON_TXVREF | HSPPARACON_TXRISE |
> + HSPPARACON_TXRES |
> + HSPPARACON_TXPREEMPPULSE |
> + HSPPARACON_TXPREEMPAMP |
> + HSPPARACON_TXHSXV | HSPPARACON_TXFSLS |
> + HSPPARACON_SQRX | HSPPARACON_OTG |
> + HSPPARACON_COMPDIS),
> + (FIELD_PREP_CONST(HSPPARACON_TXVREF, 15) |
> + FIELD_PREP_CONST(HSPPARACON_TXRISE, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXRES, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXPREEMPPULSE, 0) |
> + FIELD_PREP_CONST(HSPPARACON_TXPREEMPAMP, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXHSXV, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXFSLS, 3) |
> + FIELD_PREP_CONST(HSPPARACON_SQRX, 7) |
> + FIELD_PREP_CONST(HSPPARACON_OTG, 2) |
> + FIELD_PREP_CONST(HSPPARACON_COMPDIS, 7))),
> + PHY_TUNING_ENTRY_LAST
> +};
> +
> +static const struct exynos5_usbdrd_phy_tuning *exynos5515_tunes[PTS_MAX] = {
> + [PTS_UTMI_POSTINIT] = exynos5515_tunes_utmi_postinit,
> +};
> +
> +static const struct exynos5_usbdrd_phy_drvdata exynos5515_usbdrd_phy = {
> + .phy_cfg = phy_cfg_exynos850,
> + .n_phy_cfg = ARRAY_SIZE(phy_cfg_exynos850),

.n_phy_cfg does not exist.. Please fix this

--
~Vinod