Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add Samsung S5K3L6 image sensor

From: Krzysztof Kozlowski

Date: Thu Nov 12 2026 - 06:13:48 EST


On Wed, Nov 11, 2026 at 07:46:34PM -0500, Vincent Cloutier wrote:
> From: Vincent Cloutier <vincent@xxxxxxxxxxx>
>
> Add a devicetree binding for the Samsung S5K3L6 13MP raw Bayer image
> sensor.
>
> Describe the validated two-lane MIPI CSI-2 configuration used by the
> Librem 5 rear camera, including its supplies, input clock, reset GPIO and
> three link frequencies. Require the endpoint and reset GPIO: the driver
> uses hardware reset to stop the sensor if an I2C standby write fails.
>
> Signed-off-by: Vincent Cloutier <vincent@xxxxxxxxxxx>
> Assisted-by: OpenCode:GPT-6.1 Sol

Drop tag. Also, your SoB is supposed to be the last one.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> ---
> .../bindings/media/i2c/samsung,s5k3l6.yaml | 118 ++++++++++++++++++
> 1 file changed, 118 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml
> new file mode 100644
> index 000000000000..097593d74780
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml
> @@ -0,0 +1,118 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/samsung,s5k3l6.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S5K3L6 13MP MIPI CSI-2 image sensor
> +
> +maintainers:
> + - Vincent Cloutier <vincent@xxxxxxxxxxx>
> +
> +description: |-

Drop |-


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof