Re: [PATCH] phy: rockchip: naneng-combphy: Fix overwritten PLL SSC control bit
From: Vinod Koul
Date: Thu Nov 12 2026 - 07:05:22 EST
On Thu, 15 Oct 2026 11:59:47 +0800, Shawn Lin wrote:
> rk_combphy_common_cfg_ssc() first sets RK3568_PHYREG33_PLL_SSC_CTRL on the
> RK3588 and RK3576 SoCs, then, for PCIe at 24MHz, programs the PLL KVCO
> adjust field. The latter used a plain writel() of the FIELD_PREP() value,
> which cleared all the other bits of RK3568_PHYREG33, including the
> PLL_SSC_CTRL bit that had just been set a few lines above.
>
> Use rockchip_combphy_updatel() so that only the KVCO field is updated and
> the SSC control bit is preserved, as the comment and the pre-consolidation
> code intended.
>
> [...]
Applied, thanks!
[1/1] phy: rockchip: naneng-combphy: Fix overwritten PLL SSC control bit
commit: 96246dc6c16a5e5a6b4b9fde8f4ab9cdeb201088
Best regards,
--
~Vinod