[PATCH v4 3/6] ASoC: soc-acpi: move common SOF topology helpers
From: Syed Saba Kareem
Date: Thu Nov 12 2026 - 07:44:23 EST
From: Siva Subramanian Ravi Saravanan <sravisar@xxxxxxx>
Move the SOF function topology helpers out of the Intel-specific code
so that they can be shared with other SOF platforms (e.g. AMD ACP).
The helpers operate on SOF "sof-<platform>-...tplg" topology names, so
they are renamed with an "sof" infix to reflect that they are SOF
specific:
- get_platform_name() as snd_soc_acpi_sof_get_platform_name()
- get_tplg_filename() as snd_soc_acpi_sof_get_tplg_filename()
Both helpers take a struct device pointer so that callers that only
have a struct device (such as the AMD ACP machine driver) can use them
directly.
snd_soc_acpi_sof_get_platform_name() parses the platform name out of
the "sof-<platform>-...tplg" filename. Widen the sscanf field from
"sof-%3s" to "sof-%7[^-]" so that platform names longer than three
characters are read correctly. The old "sof-%3s" field captured at most
three characters, so for a longer platform name such as the AMD "acp7f"
it stopped after "acp". That is still one successful conversion, so
sscanf() returned 1, the "ret != 1" check passed and the helper returned
success with a silently truncated platform name ("acp"), which then
produced the wrong topology file name. The "sof-%7[^-]" field instead
reads up to seven characters up to the next "-", capturing the full
"acp7f". Existing Intel platform names are three characters, so their
parsing is unchanged.
The "%7[^-]" field can write up to seven characters plus a NUL
terminator, i.e. eight bytes, into the caller-provided buffer, so every
caller must size that buffer accordingly. Add a public
SND_SOC_ACPI_SOF_PLATFORM_NAME_MAX (8) constant in soc-acpi.h as the
single authoritative buffer size and use it for the Intel platform
buffers, replacing the local SOF_INTEL_PLATFORM_NAME_MAX; otherwise a
longer platform name would overflow the caller's stack buffer.
The topology-file presence check only tests whether a firmware topology
file can be requested, so it is generic. Move it to soc-topology.c as
snd_soc_tplg_files_exist() and drop the SOF-specific download hint from
its warning. As the firmware request now lives in soc-topology.c, drop
the no longer needed linux/firmware.h include from
sof-function-topology-lib.c.
The enum and the helper prototypes move to soc-acpi.h. As the enum
becomes part of a public header, rename it to
snd_soc_acpi_tplg_device_id and prefix its enumerators with
SND_SOC_ACPI_ to avoid polluting the global namespace, and rename the
Intel-specific TPLG_DEVICE_INTEL_PCH_DMIC to the vendor-neutral
SND_SOC_ACPI_TPLG_DEVICE_PCH_DMIC.
The two SOF helpers do not depend on ACPI (they only use sscanf() and
devm_kasprintf()) and are now used by the Intel match code, which is
also built on non-ACPI configurations. Select SND_SOC_ACPI
unconditionally so soc-acpi is always available (SND_SOC_ACPI is a plain
tristate with no ACPI dependency, so this does not force anything
ACPI-specific on non-ACPI builds). Because soc-acpi.c is now compiled on
non-ACPI configurations too, guard its ACPI-only matching functions
(snd_soc_acpi_id_present(), snd_soc_acpi_find_machine(),
snd_soc_acpi_find_package[_from_hid]() and snd_soc_acpi_codec_list())
with CONFIG_ACPI: they call ACPI-only APIs such as acpi_dev_present(),
acpi_fetch_acpi_dev(), acpi_evaluate_object_typed() and
acpi_get_devices(), and the header already provides stubs for the public
ones. Only the ACPI-independent SOF helpers remain exported
unconditionally. Otherwise the build fails on non-ACPI configs, either
with the helpers reported as undefined symbols or with
redefinition/implicit-declaration errors.
Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@xxxxxxx>
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@xxxxxxx>
---
include/sound/soc-acpi.h | 30 ++++
include/sound/soc-topology.h | 10 ++
sound/soc/intel/Kconfig | 2 +-
.../intel/common/sof-function-topology-lib.c | 129 ++++--------------
sound/soc/soc-acpi.c | 51 +++++++
sound/soc/soc-topology.c | 16 +++
6 files changed, 135 insertions(+), 103 deletions(-)
diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h
index 2ee303b791dc..b850295e9584 100644
--- a/include/sound/soc-acpi.h
+++ b/include/sound/soc-acpi.h
@@ -257,4 +257,34 @@ bool snd_soc_acpi_sdw_link_slaves_found(struct device *dev,
const struct snd_soc_acpi_link_adr *link,
struct sdw_peripherals *peripherals);
+enum snd_soc_acpi_tplg_device_id {
+ SND_SOC_ACPI_TPLG_DEVICE_SDCA_JACK,
+ SND_SOC_ACPI_TPLG_DEVICE_SDCA_AMP,
+ SND_SOC_ACPI_TPLG_DEVICE_SDCA_MIC,
+ SND_SOC_ACPI_TPLG_DEVICE_PCH_DMIC,
+ SND_SOC_ACPI_TPLG_DEVICE_HDMI,
+ SND_SOC_ACPI_TPLG_DEVICE_SSP_JACK,
+ SND_SOC_ACPI_TPLG_DEVICE_SSP_AMP,
+ SND_SOC_ACPI_TPLG_DEVICE_SSP_BT,
+ SND_SOC_ACPI_TPLG_DEVICE_SSP_HDMI_IN,
+ SND_SOC_ACPI_TPLG_DEVICE_LOOPBACK_VIRTUAL,
+ SND_SOC_ACPI_TPLG_DEVICE_MAX
+};
+
+/*
+ * Minimum size, including the trailing NUL, of the buffer that
+ * snd_soc_acpi_sof_get_platform_name() fills from a
+ * "sof-<platform>-...tplg" topology file name. The "sof-%7[^-]"
+ * conversion can write up to seven characters plus a NUL terminator,
+ * so callers must provide a buffer of at least this size.
+ */
+#define SND_SOC_ACPI_SOF_PLATFORM_NAME_MAX 8
+
+int snd_soc_acpi_sof_get_platform_name(struct device *dev,
+ const struct snd_soc_acpi_mach *mach, char *platform);
+char *snd_soc_acpi_sof_get_tplg_filename(struct device *dev, const char *prefix,
+ const char *platform, const char *tplg_dev_name,
+ int dai_link_id,
+ enum snd_soc_acpi_tplg_device_id tplg_dev);
+
#endif
diff --git a/include/sound/soc-topology.h b/include/sound/soc-topology.h
index 1eedd203ac29..cf5c9bd1037e 100644
--- a/include/sound/soc-topology.h
+++ b/include/sound/soc-topology.h
@@ -30,6 +30,7 @@ struct snd_soc_dai_link;
struct snd_soc_dai_driver;
struct snd_soc_dai;
struct snd_soc_dapm_route;
+struct device;
/* dynamic object type */
enum snd_soc_dobj_type {
@@ -181,6 +182,9 @@ int snd_soc_tplg_component_load(struct snd_soc_component *comp,
const struct snd_soc_tplg_ops *ops, const struct firmware *fw);
int snd_soc_tplg_component_remove(struct snd_soc_component *comp);
+/* Check for presence of topology firmware files */
+bool snd_soc_tplg_files_exist(struct device *dev, const char *tplg_files);
+
/* Binds event handlers to dynamic widgets */
int snd_soc_tplg_widget_bind_event(struct snd_soc_dapm_widget *w,
const struct snd_soc_tplg_widget_events *events, int num_events,
@@ -193,6 +197,12 @@ static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp)
return 0;
}
+static inline bool snd_soc_tplg_files_exist(struct device *dev,
+ const char *tplg_files)
+{
+ return false;
+}
+
#endif
#endif
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 63367364916a..af08efa0ac1d 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -72,7 +72,7 @@ if SND_SOC_INTEL_SST_TOPLEVEL || SND_SOC_SOF_INTEL_TOPLEVEL
config SND_SOC_ACPI_INTEL_MATCH
tristate
- select SND_SOC_ACPI if ACPI
+ select SND_SOC_ACPI
select SND_SOC_ACPI_INTEL_SDCA_QUIRKS
# this option controls the compilation of ACPI matching tables and
# helpers and is not meant to be selected by the user.
diff --git a/sound/soc/intel/common/sof-function-topology-lib.c b/sound/soc/intel/common/sof-function-topology-lib.c
index 57e089f8e721..aa36b9961977 100644
--- a/sound/soc/intel/common/sof-function-topology-lib.c
+++ b/sound/soc/intel/common/sof-function-topology-lib.c
@@ -8,92 +8,15 @@
#include <linux/device.h>
#include <linux/errno.h>
-#include <linux/firmware.h>
#include <sound/soc.h>
#include <sound/soc-acpi.h>
+#include <sound/soc-topology.h>
#include "sof-function-topology-lib.h"
-enum tplg_device_id {
- TPLG_DEVICE_SDCA_JACK,
- TPLG_DEVICE_SDCA_AMP,
- TPLG_DEVICE_SDCA_MIC,
- TPLG_DEVICE_INTEL_PCH_DMIC,
- TPLG_DEVICE_HDMI,
- TPLG_DEVICE_SSP_JACK,
- TPLG_DEVICE_SSP_AMP,
- TPLG_DEVICE_SSP_BT,
- TPLG_DEVICE_SSP_HDMI_IN,
- TPLG_DEVICE_LOOPBACK_VIRTUAL,
- TPLG_DEVICE_MAX
-};
-
-#define SDCA_DEVICE_MASK (BIT(TPLG_DEVICE_SDCA_JACK) | BIT(TPLG_DEVICE_SDCA_AMP) | \
- BIT(TPLG_DEVICE_SDCA_MIC))
-
-#define SOF_INTEL_PLATFORM_NAME_MAX 4
-
-static int get_platform_name(struct snd_soc_card *card,
- const struct snd_soc_acpi_mach *mach, char *platform)
-{
- int ret;
-
- ret = sscanf(mach->sof_tplg_filename, "sof-%3s-*.tplg", platform);
- if (ret != 1) {
- dev_err(card->dev, "Invalid platform name of tplg %s\n",
- mach->sof_tplg_filename);
- return -EINVAL;
- }
-
- return 0;
-}
-
-static bool tplg_files_exist(struct device *dev, const char *tplg_files)
-{
- const struct firmware *fw;
- int ret;
-
- ret = firmware_request_nowarn(&fw, tplg_files, dev);
- if (!ret) {
- release_firmware(fw);
- return true;
- }
+#define SDCA_DEVICE_MASK (BIT(SND_SOC_ACPI_TPLG_DEVICE_SDCA_JACK) | \
+ BIT(SND_SOC_ACPI_TPLG_DEVICE_SDCA_AMP) | \
+ BIT(SND_SOC_ACPI_TPLG_DEVICE_SDCA_MIC))
- dev_warn(dev,
- "Failed to open topology file: %s, you might need to\n",
- tplg_files);
- dev_warn(dev,
- "download it from https://github.com/thesofproject/sof-bin/\n");
- return false;
-}
-
-static char *get_tplg_filename(struct device *dev, const char *prefix,
- const char *platform, const char *tplg_dev_name,
- int dai_link_id, int tplg_dev)
-{
- char *filename = NULL;
-
- /*
- * The tplg file naming rule is sof-<platform>-<function>-id<BE id number>.tplg
- * where <platform> is required for functions that depend on NHLT blobs (e.g. DMIC/SSP)
- * as the nhlt blob is platform dependent.
- */
- switch (tplg_dev) {
- case TPLG_DEVICE_INTEL_PCH_DMIC:
- case TPLG_DEVICE_SSP_JACK:
- case TPLG_DEVICE_SSP_AMP:
- case TPLG_DEVICE_SSP_BT:
- case TPLG_DEVICE_SSP_HDMI_IN:
- filename = devm_kasprintf(dev, GFP_KERNEL, "%s/sof-%s-%s-id%d.tplg",
- prefix, platform, tplg_dev_name, dai_link_id);
- break;
- default:
- filename = devm_kasprintf(dev, GFP_KERNEL, "%s/sof-%s-id%d.tplg",
- prefix, tplg_dev_name, dai_link_id);
- break;
- }
-
- return filename;
-}
static int get_dmic_tplg_dev(struct device *dev, int dmic_num,
int *tplg_dev, char **tplg_dev_name)
@@ -111,7 +34,7 @@ static int get_dmic_tplg_dev(struct device *dev, int dmic_num,
dmic_num);
return -EINVAL;
}
- *tplg_dev = TPLG_DEVICE_INTEL_PCH_DMIC;
+ *tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_PCH_DMIC;
return 0;
}
@@ -131,16 +54,16 @@ static int get_ssp_tplg_dev(struct device *dev, struct snd_soc_dai_link *dai_lin
* machine drivers
*/
if (dai_link->id == 0) {
- *tplg_dev = TPLG_DEVICE_SSP_JACK;
+ *tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SSP_JACK;
*tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
"ssp%d-jack", ssp_port);
} else {
- *tplg_dev = TPLG_DEVICE_SSP_AMP;
+ *tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SSP_AMP;
*tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
"ssp%d-amp", ssp_port);
}
} else if (strstr(dai_link->name, "BT")) {
- *tplg_dev = TPLG_DEVICE_SSP_BT;
+ *tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SSP_BT;
*tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
"ssp%d-bt", ssp_port);
} else if (strstr(dai_link->name, "HDMI")) {
@@ -149,7 +72,7 @@ static int get_ssp_tplg_dev(struct device *dev, struct snd_soc_dai_link *dai_lin
if (hweight16(*hdmi_in_mask) != 2)
return -EINVAL;
- *tplg_dev = TPLG_DEVICE_SSP_HDMI_IN;
+ *tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SSP_HDMI_IN;
*tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
"ssp%x-hdmiin", *hdmi_in_mask);
} else {
@@ -173,7 +96,7 @@ int sof_sdw_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
*/
struct snd_soc_acpi_mach_params mach_params = card_mach->mach_params;
struct snd_soc_dai_link *dai_link;
- char platform[SOF_INTEL_PLATFORM_NAME_MAX];
+ char platform[SND_SOC_ACPI_SOF_PLATFORM_NAME_MAX];
unsigned long tplg_mask = 0;
u16 hdmi_in_mask = 0;
int tplg_num = 0;
@@ -182,7 +105,7 @@ int sof_sdw_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
int ret;
int i;
- ret = get_platform_name(card, mach, platform);
+ ret = snd_soc_acpi_sof_get_platform_name(card->dev, mach, platform);
if (ret < 0)
return ret;
@@ -191,30 +114,30 @@ int sof_sdw_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
dev_dbg(card->dev, "dai_link %s id %d\n", dai_link->name, dai_link->id);
if (strstr(dai_link->name, "SimpleJack")) {
- tplg_dev = TPLG_DEVICE_SDCA_JACK;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SDCA_JACK;
tplg_dev_name = "sdca-jack";
} else if (strstr(dai_link->name, "SmartAmp")) {
- tplg_dev = TPLG_DEVICE_SDCA_AMP;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SDCA_AMP;
tplg_dev_name = devm_kasprintf(card->dev, GFP_KERNEL,
"sdca-%damp", dai_link->num_cpus);
if (!tplg_dev_name)
return -ENOMEM;
} else if (strstr(dai_link->name, "SmartMic")) {
- tplg_dev = TPLG_DEVICE_SDCA_MIC;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_SDCA_MIC;
tplg_dev_name = "sdca-mic";
} else if (strstr(dai_link->name, "dmic")) {
if (get_dmic_tplg_dev(card->dev, mach_params.dmic_num,
&tplg_dev, &tplg_dev_name) < 0)
continue;
} else if (strstr(dai_link->name, "iDisp")) {
- tplg_dev = TPLG_DEVICE_HDMI;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_HDMI;
tplg_dev_name = "hdmi-pcm5";
} else if (strstr(dai_link->name, "SSP")) {
if (get_ssp_tplg_dev(card->dev, dai_link, &hdmi_in_mask,
&tplg_dev, &tplg_dev_name) < 0)
continue;
} else if (strstr(dai_link->name, "Loopback_Virtual")) {
- tplg_dev = TPLG_DEVICE_LOOPBACK_VIRTUAL;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_LOOPBACK_VIRTUAL;
/*
* Mark the LOOPBACK_VIRTUAL device but no need to create the
* LOOPBACK_VIRTUAL topology. Just to avoid the dai_link is not supported
@@ -235,13 +158,14 @@ int sof_sdw_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
if (tplg_mask & BIT(tplg_dev))
continue;
- tplg_file = get_tplg_filename(card->dev, prefix, platform, tplg_dev_name,
- dai_link->id, tplg_dev);
+ tplg_file = snd_soc_acpi_sof_get_tplg_filename(card->dev, prefix,
+ platform, tplg_dev_name,
+ dai_link->id, tplg_dev);
if (!tplg_file)
return -ENOMEM;
/* Check presence of sub-topologies */
- if (!tplg_files_exist(card->dev, tplg_file)) {
+ if (!snd_soc_tplg_files_exist(card->dev, tplg_file)) {
devm_kfree(card->dev, tplg_file);
if (best_effort)
continue;
@@ -266,7 +190,7 @@ int sof_i2s_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
{
struct snd_soc_acpi_mach_params mach_params = mach->mach_params;
struct snd_soc_dai_link *dai_link;
- char platform[SOF_INTEL_PLATFORM_NAME_MAX];
+ char platform[SND_SOC_ACPI_SOF_PLATFORM_NAME_MAX];
unsigned long tplg_mask = 0;
u16 hdmi_in_mask = 0;
int tplg_num = 0;
@@ -275,7 +199,7 @@ int sof_i2s_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
int ret;
int i;
- ret = get_platform_name(card, mach, platform);
+ ret = snd_soc_acpi_sof_get_platform_name(card->dev, mach, platform);
if (ret < 0)
return ret;
@@ -292,7 +216,7 @@ int sof_i2s_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
&tplg_dev, &tplg_dev_name) < 0)
continue;
} else if (strstr(dai_link->name, "iDisp")) {
- tplg_dev = TPLG_DEVICE_HDMI;
+ tplg_dev = SND_SOC_ACPI_TPLG_DEVICE_HDMI;
tplg_dev_name = "hdmi-pcm5";
} else {
/* The dai link is not supported by separated tplg yet */
@@ -307,13 +231,14 @@ int sof_i2s_get_tplg_files(struct snd_soc_card *card, const struct snd_soc_acpi_
if (tplg_mask & BIT(tplg_dev))
continue;
- tplg_file = get_tplg_filename(card->dev, prefix, platform, tplg_dev_name,
- dai_link->id, tplg_dev);
+ tplg_file = snd_soc_acpi_sof_get_tplg_filename(card->dev, prefix,
+ platform, tplg_dev_name,
+ dai_link->id, tplg_dev);
if (!tplg_file)
return -ENOMEM;
/* Check presence of sub-topologies */
- if (!tplg_files_exist(card->dev, tplg_file)) {
+ if (!snd_soc_tplg_files_exist(card->dev, tplg_file)) {
devm_kfree(card->dev, tplg_file);
if (best_effort)
continue;
diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 270f9777942f..1c6e20e00dca 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -4,10 +4,12 @@
//
// Copyright (c) 2013-15, Intel Corporation.
+#include <linux/device.h>
#include <linux/export.h>
#include <linux/module.h>
#include <sound/soc-acpi.h>
+#if IS_ENABLED(CONFIG_ACPI)
static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine)
{
const struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids;
@@ -124,6 +126,7 @@ struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
return mach;
}
EXPORT_SYMBOL_GPL(snd_soc_acpi_codec_list);
+#endif /* CONFIG_ACPI */
#define SDW_CODEC_ADR_MASK(_adr) ((_adr) & (SDW_DISCO_LINK_ID_MASK | SDW_VERSION_MASK | \
SDW_MFG_ID_MASK | SDW_PART_ID_MASK))
@@ -200,5 +203,53 @@ bool snd_soc_acpi_sdw_link_slaves_found(struct device *dev,
}
EXPORT_SYMBOL_GPL(snd_soc_acpi_sdw_link_slaves_found);
+int snd_soc_acpi_sof_get_platform_name(struct device *dev,
+ const struct snd_soc_acpi_mach *mach, char *platform)
+{
+ int ret;
+
+ /* platform must hold at least SND_SOC_ACPI_SOF_PLATFORM_NAME_MAX bytes */
+ ret = sscanf(mach->sof_tplg_filename, "sof-%7[^-]-*.tplg", platform);
+ if (ret != 1) {
+ dev_err(dev, "Invalid platform name of tplg %s\n",
+ mach->sof_tplg_filename);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(snd_soc_acpi_sof_get_platform_name);
+
+char *snd_soc_acpi_sof_get_tplg_filename(struct device *dev, const char *prefix,
+ const char *platform, const char *tplg_dev_name,
+ int dai_link_id,
+ enum snd_soc_acpi_tplg_device_id tplg_dev)
+{
+ char *filename = NULL;
+
+ /*
+ * The tplg file naming rule is sof-<platform>-<function>-id<BE id number>.tplg
+ * where <platform> is required for functions that depend on NHLT blobs (e.g. DMIC/SSP)
+ * as the nhlt blob is platform dependent.
+ */
+ switch (tplg_dev) {
+ case SND_SOC_ACPI_TPLG_DEVICE_PCH_DMIC:
+ case SND_SOC_ACPI_TPLG_DEVICE_SSP_JACK:
+ case SND_SOC_ACPI_TPLG_DEVICE_SSP_AMP:
+ case SND_SOC_ACPI_TPLG_DEVICE_SSP_BT:
+ case SND_SOC_ACPI_TPLG_DEVICE_SSP_HDMI_IN:
+ filename = devm_kasprintf(dev, GFP_KERNEL, "%s/sof-%s-%s-id%d.tplg",
+ prefix, platform, tplg_dev_name, dai_link_id);
+ break;
+ default:
+ filename = devm_kasprintf(dev, GFP_KERNEL, "%s/sof-%s-id%d.tplg",
+ prefix, tplg_dev_name, dai_link_id);
+ break;
+ }
+
+ return filename;
+}
+EXPORT_SYMBOL_GPL(snd_soc_acpi_sof_get_tplg_filename);
+
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("ALSA SoC ACPI module");
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 35cbe29d2275..eb72cf741b8e 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -2245,3 +2245,19 @@ int snd_soc_tplg_component_remove(struct snd_soc_component *comp)
return !list_empty(&comp->dobj_list);
}
EXPORT_SYMBOL_GPL(snd_soc_tplg_component_remove);
+
+bool snd_soc_tplg_files_exist(struct device *dev, const char *tplg_files)
+{
+ const struct firmware *fw;
+ int ret;
+
+ ret = firmware_request_nowarn(&fw, tplg_files, dev);
+ if (!ret) {
+ release_firmware(fw);
+ return true;
+ }
+
+ dev_warn(dev, "Failed to open topology file: %s\n", tplg_files);
+ return false;
+}
+EXPORT_SYMBOL_GPL(snd_soc_tplg_files_exist);
--
2.43.0