Re: [PATCH 01/13] mm/mmap: free gathered pages before MMF_OOM_SKIP

[Lorenzo Stoakes (ARM)]

On Thu, Nov 12, 2026 at 12:28:50PM +0000, Pedro Falcato wrote:
> On Thu, Nov 12, 2026 at 12:18:46PM +0000, Lorenzo Stoakes (ARM) wrote:
> > On Thu, Nov 12, 2026 at 12:17:21PM +0000, Lorenzo Stoakes (ARM) wrote:
> > > On Thu, Nov 12, 2026 at 11:21:38AM +0000, Pedro Falcato wrote:
> > > > Reviewed-by: Pedro Falcato <pfalcato@xxxxxxx>
> > >
> > > Thanks!
> > >
> > > > > diff --git a/mm/mmap.c b/mm/mmap.c
> > > > > index 7618e72766a5..4cb18b217048 100644
> > > > > --- a/mm/mmap.c
> > > > > +++ b/mm/mmap.c
> > > > > @@ -1313,11 +1313,18 @@ void exit_mmap(struct mm_struct *mm)
> > > [ ... ]
> > > > > +	if (mm_is_oom_victim(mm))
> > > > > +		tlb_flush_mmu(&tlb);
> > > >
> > > > I see there's a different tlb_flush_mmu() call below (in the actual function).
> > > > Is tlb_flush_mmu() idempotent?
> > >
> > > No, tlb_flush_mmu() is cromulent.
>
> Naturally.
>
> >
> > (kidding, yes it's idempotent :P)
>
> Great! Thanks for the cromulent reply.

That's gracious of you to say. I'm glad it has embiggened the debate,
however serendipitously, and I can only hope it hasn't furthered the cause
of antidisestablishmentarianism.

--
Cheers, Lorenzo