Re: [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments

[Florian Westphal]

Jérémy Jean <Jeremy.Jean@xxxxxxxxxxxxxxxxx> wrote:
> +		if ((flkeys.control.flags & FLOW_DIS_IS_FRAGMENT) &&
> +		    ipv6_find_hdr(skb, &offset, -1, NULL, &fh_flags) >= 0 &&
> +		    (fh_flags & IP6_FH_F_FRAG) &&
> +		    !(fh_flags & IP6_FH_F_NON_ATOMIC)) {

Since you need to send a new version anyway, maybe avoid
double-neg, i.e.: (fh_flags & IP6_FH_F_ATOMIC) ?