Re: [PATCH RFC v10 07/22] arm64: Initialize POR_EL1 register on cpu_resume()

From: Yeoreum Yun

Date: Thu Nov 12 2026 - 08:32:31 EST


On Thu, Nov 12, 2026 at 01:02:16PM +0000, Mark Brown wrote:
> On Thu, Nov 12, 2026 at 01:38:13PM +0100, Kevin Brodsky wrote:
> > On 10/11/2026 17:36, Yeoreum Yun wrote:
>
> > > Thanks. seems required to isb() after initialising SYS_POR_EL1.
>
> > Agreed (as Sashiko reported as well). Presumably that means we also need
> > an ISB after writing to POR_EL1 in cpu_enable_poe(), as that's basically
> > the same situation.
>
> Possibly just have one before writing TCR2_EL1 rather than for each of
> the indvididual features, that's harder to mess up?

I'm not sure that's necessarily better, as we'd end up executing an isb()
even when POE or other features aren't enabled.
Wouldn't it be better to execute an isb() only when needed?

--
Sincerely,
Yeoreum Yun