Re: [PATCH RFC v10 07/22] arm64: Initialize POR_EL1 register on cpu_resume()
From: Kevin Brodsky
Date: Thu Nov 12 2026 - 08:42:30 EST
On 12/11/2026 14:02, Mark Brown wrote:
>> Agreed (as Sashiko reported as well). Presumably that means we also need
>> an ISB after writing to POR_EL1 in cpu_enable_poe(), as that's basically
>> the same situation.
> Possibly just have one before writing TCR2_EL1 rather than for each of
> the indvididual features, that's harder to mess up?
cpu_enable_poe() directly writes to TCR2_EL1 so surely the extra ISB has
to be there (between writing to POR_EL1 and writing to TCR2_EL1)?
In _cpu_resume for now I'd keep the ISB directly after writing to
POR_EL1, as I'm not sure the ordering is needed for anything but POE and
it seems easier to follow with the ISB right after POR_EL1.
- Kevin