[PATCH v4] media: dvb-core: skip disable_source handler for a released entity
From: YuanZhe Liu
Date: Thu Nov 12 2026 - 08:50:30 EST
dvb_remove_device() frees the media entity of a dvb_device through
dvb_media_device_free() and sets dvbdev->entity to NULL. The media
device of the adapter can still be registered at that point: au0828,
for example, only clears mdev->disable_source in au0828_usb_release(),
which runs after au0828_dvb_unregister() has unregistered the frontend
device.
A file descriptor that survives the disconnect then reaches
dvb_frontend_release() with dvbdev->entity already NULL and calls
fe->dvb->mdev->disable_source(dvbdev->entity);
au0828_disable_source() dereferences that argument unconditionally:
struct media_device *mdev = entity->graph_obj.mdev;
which faults:
general protection fault: 0000 [#1] SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
RIP: au0828_disable_source+0x27/0xb70 au0828-core.c:445
Call Trace:
dvb_frontend_release+0x2eb/0x500 dvb_frontend.c:2946
The error path of __dvb_frontend_open() has the same call.
Skip the handler when dvbdev->entity is gone. Clear dvbdev->entity in
dvb_media_device_free() under mdev->graph_mutex, before the entity is
unregistered and freed: the frontend paths read the pointer under the
same lock, so a reader either still sees a registered entity, for which
unregister waits, or sees NULL. Clearing the pointer after the
unregister would leave a window in which the entity is read after it was
already freed.
The entity can exist without a media device when registration failed:
media_device_register_entity() destroys the graph object in its error
path, and media_gobj_destroy() clears graph_obj.mdev. There is no lock
to take in that case, so the pointer is cleared unconditionally and only
the lock is conditional.
Stopping the pipeline the handler started is not done here. Only the
driver knows how to release the link it owns, and dvb_media_device_free()
runs for every dvb_device, including the demux, dvr and ca entities that
never own a media link; calling the handler for those would deactivate a
link owned by another entity. The au0828 driver stops the pipeline and
clears its saved link in au0828_usb_disconnect(), before the frontend
entity is unregistered, in a separate patch.
Fixes: 68ff5767ddc4 ("[media] media: dvb-frontend invoke enable/disable_source handlers")
Cc: stable@xxxxxxxxxxxxxxx
Co-developed-by: Bin Yu <byu@xxxxxxxxxxxxx>
Signed-off-by: Bin Yu <byu@xxxxxxxxxxxxx>
Co-developed-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: YuanZhe Liu <25031212351@xxxxxxxxxxxxxxxxx>
---
Changes in v4:
- Clear dvbdev->entity under mdev->graph_mutex, as suggested by Hans
Verkuil, and check the field directly at both frontend call sites.
This replaces the local copy and the WRITE_ONCE()/READ_ONCE() pair.
Changes in v3:
- Publish dvbdev->entity with WRITE_ONCE() and read it with READ_ONCE()
at both frontend call sites, so the clear in dvb_media_device_free()
is not a plain data race with the readers that hold graph_mutex.
- State why the active pipeline is torn down by the driver rather than
in dvb-core. The matching au0828 change is attached to this mail.
Link: https://lore.kernel.org/r/20261102142508.24277-1-25031212351@xxxxxxxxxxxxxxxxx
Changes in v2:
- Read dvbdev->entity once into a local variable under graph_mutex at both
call sites. dvb_media_device_free() clears the pointer without holding
that lock, so re-reading the field for the call argument could still pass
NULL to the handler.
---
drivers/media/dvb-core/dvb_frontend.c | 4 ++--
drivers/media/dvb-core/dvbdev.c | 20 +++++++++++++++++---
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
index 0286da57f382..a4301e142ea5 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -2827,7 +2827,7 @@ static int __dvb_frontend_open(struct inode *inode, struct file *file)
mutex_lock(&fe->dvb->mdev_lock);
if (fe->dvb->mdev) {
mutex_lock(&fe->dvb->mdev->graph_mutex);
- if (fe->dvb->mdev->disable_source)
+ if (dvbdev->entity && fe->dvb->mdev->disable_source)
fe->dvb->mdev->disable_source(dvbdev->entity);
mutex_unlock(&fe->dvb->mdev->graph_mutex);
}
@@ -2942,7 +2942,7 @@ static int dvb_frontend_release(struct inode *inode, struct file *file)
mutex_lock(&fe->dvb->mdev_lock);
if (fe->dvb->mdev) {
mutex_lock(&fe->dvb->mdev->graph_mutex);
- if (fe->dvb->mdev->disable_source)
+ if (dvbdev->entity && fe->dvb->mdev->disable_source)
fe->dvb->mdev->disable_source(dvbdev->entity);
mutex_unlock(&fe->dvb->mdev->graph_mutex);
}
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
index d753d329502a..4c0e8e225d58 100644
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -208,10 +208,24 @@ static void dvb_media_device_free(struct dvb_device *dvbdev)
{
#if defined(CONFIG_MEDIA_CONTROLLER_DVB)
if (dvbdev->entity) {
- media_device_unregister_entity(dvbdev->entity);
- kfree(dvbdev->entity);
- kfree(dvbdev->pads);
+ struct media_entity *entity = dvbdev->entity;
+ struct media_device *mdev = entity->graph_obj.mdev;
+
+ /*
+ * Clear the pointer before the entity is unregistered and
+ * freed, under the lock the frontend open and release paths
+ * take before they hand it to the disable_source handler.
+ * The entity has no media device if registration failed.
+ */
+ if (mdev)
+ mutex_lock(&mdev->graph_mutex);
dvbdev->entity = NULL;
+ if (mdev)
+ mutex_unlock(&mdev->graph_mutex);
+
+ media_device_unregister_entity(entity);
+ kfree(entity);
+ kfree(dvbdev->pads);
dvbdev->pads = NULL;
}
--
2.34.1