Re: [PATCH v7 4/5] iommu/of: Require reg for iommu-addresses

[Vikash Garodia]

On 11/11/2026 5:32 PM, Bryan O'Donoghue wrote:
> On 06/11/2026 17:14, Vikash Garodia wrote:
> > @@ -257,6 +252,9 @@ void of_iommu_get_resv_regions(struct device *dev, 
> > struct list_head *list)
> >                   }
> >                   type = iommu_resv_region_get_type(dev, &phys, iova, 
> > length);
> > +                if (type != IOMMU_RESV_DIRECT)
> > +                    continue;
> > +
>
> This change is not about requiring a reg though, which is why it should 
> be a standalone patch with its own justifications.

This is about reg, which determines the direct mapping, hence the code 
is very much applicable to this patch. Please refer this code [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/of_iommu.c#n223

Regards,
Vikash

> Basically the patch should state why a mismatch is dropped instead of 
> being reserved.
>
> ---
> bod