Re: r8152: RX stops until rebind after -EPROTO on the bulk-in endpoint
From: Magnus Leatti
Date: Thu Nov 12 2026 - 10:02:58 EST
On Mon, 2 Nov 2026 13:51:25 +0100, Michal Pecio wrote:
> This patch works for the simplified case, you could try if it helps
> with your issues too.
Hi Michal,
I tried it on a different chip and a different host controller:
Device: RTL8153, 0bda:8153, bcdDevice 31.00
Host: AMD Renoir/Cezanne xHCI, 1022:1639, 5 Gbps
I applied it to v7.3.3 (offsets only) with your trigger uncommented,
and built a control from the same tree with only the trigger. Each
round was down / ethtool / up, then 10 pings to the gateway through
the adapter:
trigger only: 0/10 in all 3 rounds, rx_packets flat, still
dead 30 s later; RX came back only after a rebind
trigger + patch: 10/10 in all 3 rounds
Without the patch it's the loop Dane saw, but slower here:
Transfer error + Hard-reset about every 8 ms (~122/s instead of
~275/s). With the patch, round 1:
+0.0 ms Transfer error for slot 3 ep 2 on endpoint
+0.6 ms Soft-reset ep 2, slot 3
(3 more Transfer error + Soft-reset, ~8 ms apart)
+32.5 ms Transfer error for slot 3 ep 2 on endpoint
+33.2 ms waiting for ep 0x81 clear halt
+33.7 ms Hard-reset ep 2, slot 3
+35.8 ms usb_clear_halt(pipe_in): 0
usb_clear_halt() returned 0 in all 8 recoveries I ran. On this
controller the soft retries are ~8 ms apart, so the hard reset comes
at about +32 ms rather than Dane's +15 ms.
I also put load on it: iperf3 -R for 60 s through the adapter gave
930 Mbit/s on stock 7.2.14 and 937 Mbit/s patched, and 936 Mbit/s
for 60 s right after a recovery, with no transfer errors and
rx_errors at 0. So here, after the clear halt, the chip went back to
filling new URBs cleanly.
This is still the simplified case. The trigger only bites while RX
is idle; with URBs queued, the reset is refused ("EP not empty,
refuse reset"), so I couldn't produce an error mid-transfer.
Thanks for the trigger, it made this quite straightforward to reproduce :)!
Tested-by: Magnus Leatti <magnusleatti@xxxxxxxxxxxxxx>
Magnus