Re: [PATCH 2/2] ASoC: tegra: ADMAIF: Add Tegra268 support
From: Mark Brown
Date: Thu Nov 12 2026 - 10:16:29 EST
> Tegra268 reuses the Tegra264 ADMAIF register layout but provides only
> five RX and five TX interfaces. Add the compatible and SoC data for
> this configuration.
>
> Add register defaults and five-entry DAI and control tables. Retain
> the Tegra264 32-channel per-stream limit and use Tegra268 FIFO defaults.
>
> Set the register bound one stride past the final global TX enable
> status register so the access callbacks mark it readable and volatile.
> +/* Tegra268 specific */
> +#define TEGRA268_ADMAIF_CHANNEL_COUNT 5
> +#define TEGRA268_ADMAIF_RX_BASE TEGRA264_ADMAIF_RX_BASE
> +#define TEGRA268_ADMAIF_TX_BASE TEGRA264_ADMAIF_TX_BASE
> +#define TEGRA268_ADMAIF_GLOBAL_BASE TEGRA264_ADMAIF_GLOBAL_BASE
> +#define TEGRA268_ADMAIF_LAST_REG (TEGRA268_ADMAIF_GLOBAL_BASE + \
> + TEGRA_ADMAIF_GLOBAL_TX_ENABLE_STATUS + 4)
This is the one stride beyond thing from the changelog, I've got to say
I don't follow the reasoning there. Why do we need an address one
beyond the last one that exists to be readable and volatile, and why is
this different to the other Tegra devices?
--
Mark Brown <broonie@xxxxxxxxxx>