Re: [PATCH v9 0/3] KEYS: Replace assoc_array with rhashtable
From: Jarkko Sakkinen
Date: Thu Nov 12 2026 - 10:18:32 EST
On Tue, Nov 10, 2026 at 07:33:20AM +0200, Jarkko Sakkinen wrote:
> The keyrings subsystem is the sole user of assoc_array. It has over 1700
> lines of code, no test suite, and a long history of bugs, with LLMs now
> finding more.
>
> This unfortunate outcome has evolved over time by large from the shortage
> of in-kernel callers, time bandwidth and 3rd party contributors. What the
> keyrings subsystem needs is just a generic key-value store, which performs
> well with sparse key sets. Replace assoc_array with an rhashtable-backed
> keyring index and remove assoc_array from the kernel.
Hmm...
- 1/3: 2x R-by
- 2/3: 1x R-by
- 3/3: 1x R-by
Does anyone want to bring something up, and should I just apply these?
I'm lost of ideas what to do with this further.
The only thing that comes up to my mind is whether it would be smart to
stick to ids instead of moving back to addresses. This is not actually
important (and can be always revisited).
Br, Jarkko